Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Action for linting #26

Open
GabrielDougherty opened this issue Nov 9, 2021 · 2 comments
Open

Add GitHub Action for linting #26

GabrielDougherty opened this issue Nov 9, 2021 · 2 comments
Assignees
Labels
cleanup Stay fresh feature New feature or request

Comments

@GabrielDougherty
Copy link
Contributor

It would be nice to have a GitHub Action set up for code autoformatting. Maybe we could use the existing Buildifier GitHub Action: https://github.com/thompsonja/bazel-buildifier

@spietras spietras self-assigned this Nov 11, 2021
@spietras spietras added cleanup Stay fresh feature New feature or request labels Nov 11, 2021
@spietras
Copy link
Owner

I'm always reluctant to enforce automatic formatting because no formatter is perfect and there might be other issues with commit authorship or permission to commit on forks (more points here).

Another option would be just linting. So the action would run a static analysis of code (including logical errors or simply formatting) on each pull request and fail if something is wrong. Then the PR author would need to resolve the errors and format code manually.

What do you think about that?

@GabrielDougherty
Copy link
Contributor Author

Sure, that is fine with me. Let's do linting.

@GabrielDougherty GabrielDougherty changed the title Add GitHub Action for code formatting Add GitHub Action for linting Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Stay fresh feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants