Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display commit ID to user along with Sphere version #322

Open
DaVince opened this issue Dec 23, 2020 · 2 comments
Open

Display commit ID to user along with Sphere version #322

DaVince opened this issue Dec 23, 2020 · 2 comments

Comments

@DaVince
Copy link

DaVince commented Dec 23, 2020

When compiling from source, the version is:

miniSphere X.X.X JS game engine [x64]

I suggest displaying a shortened commit id after it (on both official releases and self-compiled versions), which is useful for troubleshooting.

@fatcerberus
Copy link
Member

The convention has actually recently changed along with the rebranding; the new convention is:

neoSphere 5.5.2+ JS game engine [x64]

i.e. the version number of the last official release followed by a plus sign +, rather than just X.X.X. (note Oozaru now uses the new convention too). Of course this still doesn't tell you the exact commit, but at least shows which release it's based off of. Having an actual commit ID there would be more difficult, since the displayed version number is managed manually at present. So we'd need to automate that first, as it's impractical to manually edit the commit ID before every single commit.

@fatcerberus fatcerberus changed the title Display commit id after Sphere version Display commit ID to user along with Sphere version Dec 23, 2020
@fatcerberus
Copy link
Member

It occurs to me that the commit IDs can't actually go into the commits themselves, since you would have to:

  1. Prepare a commit
  2. Get the commit ID of the change
  3. Fill in the commit ID in the source
  4. Commit to the repository

The problem here is that Step 3 would necessarily change the commit ID. So it would need to be filled in at build time, which is tricky since the build process fundamentally differs depending on the OS. Windows builds are done with MSVC, macOS with Xcode, and Linux with make.

This will need further thought, it seems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants