Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sample formula metadata to the plan windows #343

Open
canismarko opened this issue Jan 15, 2025 · 2 comments
Open

Add sample formula metadata to the plan windows #343

canismarko opened this issue Jan 15, 2025 · 2 comments
Assignees
Labels
Firefly Issues related to the Firefly GUI system good first issue Good for newcomers

Comments

@canismarko
Copy link
Contributor

Per Haven developers meeting on 2025-01-14:

We want to add "sample_formula" as a metadata key to standard plans. To do this, we need a QLineEdit on each plan window.

We also want to include some placeholder text that provides a sample of how to consistently format a chemical formula. How precise should we get with this? Some common Li battery cathodes would be "LiNi0.8Mn0.1Co0.1O2" and "LiNi1/3Mn1/3Co1/3O2". LaTeX formatting? Something else? Too niche to care?

@canismarko canismarko added good first issue Good for newcomers Firefly Issues related to the Firefly GUI system labels Jan 15, 2025
@Cathyhjj
Copy link
Collaborator

I think I preferred the "LiNi0.8Mn0.1Co0.1O2" rather than fractions or latex formatting.

Or maybe all of them are fine, instead, we can do a smarter query similar to Material Project? like 'Li-Mn-Ni-O', so this will show up the LNMO no matter which formats ppl use?
image
image

@canismarko
Copy link
Contributor Author

I think I preferred the "LiNi0.8Mn0.1Co0.1O2" rather than fractions or latex formatting.

Well some materials need fractions, the one I included is a specific material for battery cathodes (NMC-111). I agree that the LaTeX formatting shouldn't be required, though.

For searching for an exact formula, you would need a way to handle elements being in arbitrary order (e.g. NiMnCoO2 vs MnCoNiO2). The trick will be turning the query string ("Eu2SiCl2O3") into one or more Tiled queries. Do you see a path toward doing that? I suspect materials project has several fields to keep track of chemical formulae. Or else some black magic involving regular expressions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Firefly Issues related to the Firefly GUI system good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants