Skip to content

Commit e4c4ffb

Browse files
olafurpgolafurpg
authored
Merge pull request #682 from sourcegraph/olafurpg/reference-relationships
Fix "Find references" bug for interfaces and types
2 parents c9fd4ac + 48e351f commit e4c4ffb

File tree

9 files changed

+9
-9
lines changed

9 files changed

+9
-9
lines changed

‎scip-semanticdb/src/main/java/com/sourcegraph/scip_semanticdb/ScipSemanticdb.java

+2
Original file line numberDiff line numberDiff line change
@@ -441,6 +441,8 @@ && supportsReferenceRelationship(symbolInformation)
441441

442442
private static boolean supportsReferenceRelationship(SymbolInformation info) {
443443
switch (info.getKind()) {
444+
case INTERFACE:
445+
case TYPE:
444446
case CLASS:
445447
case OBJECT:
446448
case PACKAGE_OBJECT:

‎tests/snapshots/src/main/generated/com/airbnb/epoxy/BaseEpoxyTouchCallback.java

-2
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@
88
interface BaseEpoxyTouchCallback<T extends EpoxyModel> {
99
// ^^^^^^^^^^^^^^^^^^^^^^ definition semanticdb maven . . com/airbnb/epoxy/BaseEpoxyTouchCallback#
1010
// documentation ```java\ninterface BaseEpoxyTouchCallback<T extends EpoxyModel>\n```
11-
// relationship is_reference is_implementation semanticdb maven . . com/airbnb/epoxy/EpoxyDragCallback#
12-
// relationship is_reference is_implementation semanticdb maven . . com/airbnb/epoxy/EpoxySwipeCallback#
1311
// ^ definition semanticdb maven . . com/airbnb/epoxy/BaseEpoxyTouchCallback#[T]
1412
// documentation ```java\nT extends EpoxyModel\n```
1513
// ^^^^^^^^^^ reference semanticdb maven . . com/airbnb/epoxy/EpoxyModel#

‎tests/snapshots/src/main/generated/com/airbnb/epoxy/EpoxyController.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -302,7 +302,7 @@ public EpoxyController(Handler modelBuildingHandler, Handler diffingHandler) {
302302
// ^^^^^^ reference semanticdb maven maven/androidx.annotation/annotation 1.1.0 androidx/annotation/IntDef#
303303
// ^^^^^^^^^^^^^^^^^^^^^^^ definition semanticdb maven . . com/airbnb/epoxy/EpoxyController#RequestedModelBuildType#
304304
// documentation ```java\n@Retention(RetentionPolicy.SOURCE)\n@IntDef({RequestedModelBuildType.NONE, RequestedModelBuildType.NEXT_FRAME, RequestedModelBuildType.DELAYED})\nprivate @interface RequestedModelBuildType\n```
305-
// relationship is_reference is_implementation semanticdb maven jdk 11 java/lang/annotation/Annotation#
305+
// relationship is_implementation semanticdb maven jdk 11 java/lang/annotation/Annotation#
306306
// ^^^^^^^^^^^^^^^^^^^^^^^ reference semanticdb maven . . com/airbnb/epoxy/EpoxyController#RequestedModelBuildType#
307307
// ^^^^ reference semanticdb maven . . com/airbnb/epoxy/EpoxyController#RequestedModelBuildType#NONE.
308308
RequestedModelBuildType.NEXT_FRAME,

‎tests/snapshots/src/main/generated/com/airbnb/epoxy/EpoxyDragCallback.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ public interface EpoxyDragCallback<T extends EpoxyModel> extends BaseEpoxyTouchC
1212
// ^^^^^^^^^^^^^^^^^ definition semanticdb maven . . com/airbnb/epoxy/EpoxyDragCallback#
1313
// documentation ```java\npublic interface EpoxyDragCallback<T extends EpoxyModel>\n```
1414
// documentation For use with {@link EpoxyModelTouchCallback}\n
15-
// relationship is_reference is_implementation semanticdb maven . . com/airbnb/epoxy/BaseEpoxyTouchCallback#
15+
// relationship is_implementation semanticdb maven . . com/airbnb/epoxy/BaseEpoxyTouchCallback#
1616
// ^ definition semanticdb maven . . com/airbnb/epoxy/EpoxyDragCallback#[T]
1717
// documentation ```java\nT extends EpoxyModel\n```
1818
// ^^^^^^^^^^ reference semanticdb maven . . com/airbnb/epoxy/EpoxyModel#

‎tests/snapshots/src/main/generated/com/airbnb/epoxy/EpoxySwipeCallback.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public interface EpoxySwipeCallback<T extends EpoxyModel> extends BaseEpoxyTouch
2222
// ^^^^^^^^^^^^^^^^^^ definition semanticdb maven . . com/airbnb/epoxy/EpoxySwipeCallback#
2323
// documentation ```java\npublic interface EpoxySwipeCallback<T extends EpoxyModel>\n```
2424
// documentation For use with {@link EpoxyModelTouchCallback}\n
25-
// relationship is_reference is_implementation semanticdb maven . . com/airbnb/epoxy/BaseEpoxyTouchCallback#
25+
// relationship is_implementation semanticdb maven . . com/airbnb/epoxy/BaseEpoxyTouchCallback#
2626
// ^ definition semanticdb maven . . com/airbnb/epoxy/EpoxySwipeCallback#[T]
2727
// documentation ```java\nT extends EpoxyModel\n```
2828
// ^^^^^^^^^^ reference semanticdb maven . . com/airbnb/epoxy/EpoxyModel#

‎tests/snapshots/src/main/generated/com/airbnb/epoxy/UpdateOp.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ class UpdateOp {
4444
@interface Type {
4545
// ^^^^ definition semanticdb maven . . com/airbnb/epoxy/UpdateOp#Type#
4646
// documentation ```java\n@IntDef({ADD, REMOVE, UPDATE, MOVE})\n@Retention(RetentionPolicy.SOURCE)\n@interface Type\n```
47-
// relationship is_reference is_implementation semanticdb maven jdk 11 java/lang/annotation/Annotation#
47+
// relationship is_implementation semanticdb maven jdk 11 java/lang/annotation/Annotation#
4848
}
4949

5050
static final int ADD = 0;

‎tests/snapshots/src/main/generated/com/airbnb/epoxy/VisibilityState.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ public final class VisibilityState {
4444
public @interface Visibility {
4545
// ^^^^^^^^^^ definition semanticdb maven . . com/airbnb/epoxy/VisibilityState#Visibility#
4646
// documentation ```java\n@Retention(RetentionPolicy.SOURCE)\n@IntDef({VISIBLE, INVISIBLE, FOCUSED_VISIBLE, UNFOCUSED_VISIBLE, FULL_IMPRESSION_VISIBLE, PARTIAL_IMPRESSION_VISIBLE, PARTIAL_IMPRESSION_INVISIBLE})\npublic @interface Visibility\n```
47-
// relationship is_reference is_implementation semanticdb maven jdk 11 java/lang/annotation/Annotation#
47+
// relationship is_implementation semanticdb maven jdk 11 java/lang/annotation/Annotation#
4848
}
4949

5050
/**

‎tests/snapshots/src/main/generated/tests/minimized/src/main/java/minimized/Annotations.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@
5353
public @interface Annotations {
5454
// ^^^^^^^^^^^ definition semanticdb maven . . minimized/Annotations#
5555
// documentation ```java\n@Documented\n@Retention(RetentionPolicy.RUNTIME)\n@Target({CONSTRUCTOR, FIELD, LOCAL_VARIABLE, METHOD, PACKAGE, PARAMETER, TYPE})\npublic @interface Annotations\n```
56-
// relationship is_reference is_implementation semanticdb maven jdk 11 java/lang/annotation/Annotation#
56+
// relationship is_implementation semanticdb maven jdk 11 java/lang/annotation/Annotation#
5757

5858
String value() default "";
5959
//^^^^^^ reference semanticdb maven jdk 11 java/lang/String#

‎tests/snapshots/src/main/generated/tests/minimized/src/main/java/minimized/InnerClasses.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ public interface InnerInterface<A, B> {
7272
public @interface InnerAnnotation {
7373
// ^^^^^^^^^^^^^^^ definition semanticdb maven . . minimized/InnerClasses#InnerAnnotation#
7474
// documentation ```java\npublic @interface InnerAnnotation\n```
75-
// relationship is_reference is_implementation semanticdb maven jdk 11 java/lang/annotation/Annotation#
75+
// relationship is_implementation semanticdb maven jdk 11 java/lang/annotation/Annotation#
7676
int value();
7777
// ^^^^^ definition semanticdb maven . . minimized/InnerClasses#InnerAnnotation#value().
7878
// documentation ```java\npublic abstract int value()\n```

0 commit comments

Comments
 (0)