Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Docs) Readme should mention current caveats with obtaining an access token #2

Open
benheymink opened this issue Feb 18, 2024 · 0 comments

Comments

@benheymink
Copy link

Note

(This caught me out initially, so I think updating the docs would help others, too)

Currently, the sample app obtains an access token via HTTP request/s initiated from client-side code, meaning the integration secret is exposed. The official docs mention that "...This step uses your client secret, so it should be a server-side request rather than a client-side (browser-based) request" but I think the readme for this sample app should be updated to mention it too. (If you're happy to accept external PRs I'd be happy to contribute!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant