Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filter behaviors #8242

Open
wants to merge 2 commits into
base: 4.x
Choose a base branch
from
Open

Conversation

onEXHovia
Copy link
Contributor

@onEXHovia onEXHovia commented Feb 11, 2025

Subject

Closes #8241

Changelog

### Fixed
Fix filter behaviors after migrate to stimulus

To do

  • Checkbox become not clickable
  • Filters list panel is closed after single filter is checked/unchecked
  • Filter with default value can not be turnoff

VincentLanglet
VincentLanglet previously approved these changes Feb 11, 2025
@@ -26,6 +26,10 @@ export default class extends Controller {
}

prepareSubmit() {
this.formElements
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

}
break;

default:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without default case eslint throw error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter's behavior has changed or is broken after migration to stimulus
2 participants