Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add register font to ts-sdk #934

Merged
merged 7 commits into from
Jan 31, 2025
Merged

Add register font to ts-sdk #934

merged 7 commits into from
Jan 31, 2025

Conversation

wkazmierczak
Copy link
Collaborator

No description provided.

@wkazmierczak wkazmierczak force-pushed the @wkazmierczak/add-register-font-to-ts-sdk branch from 9c6a6bd to 7e80ef4 Compare January 28, 2025 17:04
@wkazmierczak wkazmierczak force-pushed the @wkazmierczak/add-register-font-to-ts-sdk branch 4 times, most recently from cc892cc to 10aff0d Compare January 29, 2025 12:54
@wkazmierczak wkazmierczak force-pushed the @wkazmierczak/add-register-font-to-ts-sdk branch from 10aff0d to 0c9b355 Compare January 29, 2025 14:08
@wkazmierczak wkazmierczak marked this pull request as ready for review January 29, 2025 14:10
wkozyra95
wkozyra95 reviewed Jan 29, 2025
View reviewed changes
@wkazmierczak wkazmierczak linked an issue Jan 30, 2025 that may be closed by this pull request
Add register_font to ts-sdk #922
Closed
wkozyra95
wkozyra95 approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@wkozyra95 wkozyra95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging it for now, but in follow up PR

  • please address error handling in sendRequest
  • make sure passing assets works in vite example
  • modify vite examples to not use the url directlly

ts/@live-compositor/node/src/fetch.ts
if (response.status >= 400) {
const err: any = new Error(`Request to compositor failed.`);
err.response = response;
try {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we talked about it already, if json() failes then text() will also fail because body was already read. This implementation and sendRequest is incorrect

@wkozyra95 wkozyra95 merged commit 497b0bc into master Jan 31, 2025
5 checks passed
@wkozyra95 wkozyra95 deleted the @wkazmierczak/add-register-font-to-ts-sdk branch January 31, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wkozyra95 wkozyra95 wkozyra95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add register_font to ts-sdk
2 participants
@wkazmierczak @wkozyra95