Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_video_by_id() errors out if given more than 50 ids (maximum allowed by google) #38

Open
razcore-rad opened this issue Dec 17, 2019 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@razcore-rad
Copy link
Contributor

In this case get_video_by_id() should group the ids in groups of 50 and make the necessary calls. For now this just gives an error

@MerleLiuKun
Copy link
Member

I guess this error caused by the implicit parameter maxResults, I will check it, and try to do something like group the id list.

@MerleLiuKun MerleLiuKun added the enhancement New feature or request label Dec 17, 2019
@MerleLiuKun MerleLiuKun self-assigned this Dec 17, 2019
@razcore-rad
Copy link
Contributor Author

Yeah, to make it easier on yourself I think you should let _request return a list or responses too: [Response] because merging the responses gets complicated with the pageInfo and other stuff.

@razcore-rad
Copy link
Contributor Author

razcore-rad commented Dec 17, 2019

This will probably break stuff in other parts of the code, but I think it's easier in the end. You can check what experiment I tried starting from this line: https://github.com/razcore-art/python-youtube/blob/5062b01bd39c3eec202570c3786d14982de07fdb/pyyoutube/api.py#L341. I left you some comments to hopefully make it easier

@MerleLiuKun
Copy link
Member

Hey, Thanks, I will think this and try your code today. 😺 . Maybe can provide a common method. Because this may for the other resources. Such as channels and playlists etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants