Skip to content

Commit bd1742f

Browse files
Merge pull request #374 from snowflakedb/prep-1.2.8
SNOW-460679 Bump version from 1.2.7 to 1.2.8
2 parents 1faf951 + a09c058 commit bd1742f

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

Snowflake.Data/Core/Authenticator/IAuthenticator.cs

+4-5
Original file line numberDiff line numberDiff line change
@@ -90,14 +90,14 @@ protected void Login()
9090
}
9191

9292
/// <summary>
93-
/// Specialized authenticator data to add to the login request.
93+
/// Specialized authenticator data to add to the login request.
9494
/// </summary>
9595
/// <param name="data">The login request data to update.</param>
9696
protected abstract void SetSpecializedAuthenticatorData(ref LoginRequestData data);
9797

9898
/// <summary>
9999
/// Builds a simple login request. Each authenticator will fill the Data part with their
100-
/// specialized information. The common Data attributes are already filled (clientAppId,
100+
/// specialized information. The common Data attributes are already filled (clientAppId,
101101
/// ClienAppVersion...).
102102
/// </summary>
103103
/// <returns>A login request to send to the server.</returns>
@@ -181,9 +181,8 @@ internal static IAuthenticator GetAuthenticator(SFSession session)
181181

182182
return new OAuthAuthenticator(session);
183183
}
184-
// Okta would provide a url of form: https://xxxxxx.okta.com or https://xxxxxx.oktapreview.com
185-
else if ((type.EndsWith("okta.com") || type.EndsWith("oktapreview.com") )
186-
&& type.StartsWith("https://"))
184+
// Okta would provide a url of form: https://xxxxxx.okta.com or https://xxxxxx.oktapreview.com or https://vanity.url/snowflake/okta
185+
else if (type.Contains("okta") && type.StartsWith("https://"))
187186
{
188187
return new OktaAuthenticator(session, type);
189188
}

Snowflake.Data/Snowflake.Data.csproj

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
<Product>Snowflake Connector for .NET</Product>
1313
<Authors>howryu, tchen</Authors>
1414
<Copyright>Copyright (c) 2012-2019 Snowflake Computing Inc. All rights reserved.</Copyright>
15-
<Version>1.2.7</Version>
15+
<Version>1.2.8</Version>
1616
<DebugType>Full</DebugType>
1717
</PropertyGroup>
1818

0 commit comments

Comments
 (0)