-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Notes field for Locations #16184
Comments
👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can. |
@snipe Is this request just to add the "Notes" field in the "Location Object" and "Create new Location" page? I do not think this requires any backward compatibility as there is no previous notes field in the location. I would like to work on this. |
@DecodersLord - I'm not sure what you're taking about with regard to reverse compatibility. There is already a PR up for this. #16226 |
(Sorry, I forgot that GH doesn't auto-link to the GH issue if it's only in the PR title, and not in the body. Very annoying. It should have been linked here when the PR was opened, but GH can be quirky.) |
@snipe By backward compatible I just meant that if an object already had data in the Notes field it would populate after adding the Notes section it will be populated when the user views the entry. I believe it's been addressed by
Worth a try, I will keep looking to contribute here. |
Yeah, the ask here was for adding notes to one thing that literally didn't have a DB field for it (because nobody asked for it). That PR I linked to addresses this issue and adds the same functionality for a few other first class objects (aka objects that have models) |
…_etc Fixed #16184 - added notes to locations, companies, categories, manufacturers and groups
Neat! I tried the dev version 👍. One more thing (which might warrant a separate issue): There's no way of seeing the notes field without editing the location, which users might not be entitled to do. Could it be exposed elsewhere in the UI read-only? Idea 1: On the location page's right margin with the address info. |
Summary
Currently in Snipe-IT
7.1.16
Location objects don't have a freeformNotes
field (unlike many other objects). I request such a field to be added.Motivation
We have a separate system for managing locations. We synchronize this data to Snipe-IT through the API. This works nicely, but a lot of the information doesn't fit into Snipe-ITs Location representation. (Room type, floor, size etc.) A generic notes field would allow us to bring this extra info to Snipe-IT as well.
I can imagine the field being useful in non-automated contexts as well. Recording misc information like "Space has only 4 power outlets".
The text was updated successfully, but these errors were encountered: