Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the Python version and Django version you used? #1

Open
realsby opened this issue May 14, 2017 · 5 comments
Open

What is the Python version and Django version you used? #1

realsby opened this issue May 14, 2017 · 5 comments

Comments

@realsby
Copy link

realsby commented May 14, 2017

Hi. I realy enjoyed your app.
I like the logic here and i try it with Python 3 and Django 1.11.1
I makes some changes but still not working properly.
Can you tell me the verisons you used.
Ty

@realsby realsby changed the title What is the Python versino and Django version you used? What is the Python version and Django version you used? May 14, 2017
@sligodave
Copy link
Owner

Hi @realsby,

Sorry, have a new version that I must push. Django 1.11 now requires that the AppConfig class now has a "name" attribute set on it. That's probably the problem you are seeing. Having said that, I haven't tested it on python 3 yet but really should. I'll get that new version up as soon as I get to my laptop. I hope it's not holding you up too much.

Dave

@realsby
Copy link
Author

realsby commented May 14, 2017

Ty. For your response..
Finally i have managed to run project with Django 1.10 and Python 2.7.
I belive you dont have to make much changes for Python 3 support. I didnt try yet. Tomorrow I will try.

Removed encode('utf8') from
AppConfig2 = type( 'AppConfig'.encode('utf8'), (AppConfig,), {'path': '/tmp/{}'.format(self.label)} )

changed import
from io import StringIO

And I belive your project need requirements.txt and Support info etc. I will create pull requests soon. Ty.

@sligodave
Copy link
Owner

@realsby,

I take it back, Django 1.11 didn't add a requirement for the AppConfig to have a "name" attribute, it now needs an "apps" attribute and I'd already pushed the fix, so what you were seeing was a different issue.

I've got a nicely cleaned up push to make but I don't want to kill what you've been working on, so I'm going to push it to a branch called "dev". Let me know when you are good and I'll merge it into master.

Dave

sligodave pushed a commit that referenced this issue May 15, 2017
- Added a requirements file to make installs easier.
- Updated the setup.py file to include the requirements also.
- Updated the .gitignore file to include a hidden MacOS file.
sligodave pushed a commit that referenced this issue May 15, 2017
- Added support for python 3 (tested with 3.6.1)
- Broke dynamic database functionality out of the model and into it's own class.
  The model is a method to store a config for a DynamicDatabase instance but you
  no longer need a model instance to get a dynamic database instance.
  You can instantiate it yourself with a name and database config dictionary,
  identical to what you set in the settings.py file.
@sligodave
Copy link
Owner

Oh and the clean up, includes fixes so it works for Python 2 and 3.
Next up, documentation and a proper install procedure (although I did add the requirements.txt to the master branch).

Dave

@realsby
Copy link
Author

realsby commented May 16, 2017

Ty. I did not started my project yet but I will need such tool in that project. I just started R&D so you wont kill my works. You are so thoughtful and kind. You earn my respect and I would like to say that if you ever consider to come to Istanbul please contact me via my personal email [email protected].

And I hope I will check your updates tomorrow, bussy week. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants