Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Store resources as submodule #13

Open
mattrossman opened this issue Mar 30, 2023 · 3 comments
Open

[Suggestion] Store resources as submodule #13

mattrossman opened this issue Mar 30, 2023 · 3 comments

Comments

@mattrossman
Copy link
Contributor

Currently, setting up this project for local testing requires going into examples/_res and following the instructions to clone the resources repository. This can be problematic because:

  • It's an extra step that can be overlooked for contributors
  • The main branch of the repository is not guaranteed to be in sync with commits in this repository

This could be handled more elegantly with the resources repo as a Git submodule of this project.

This would mean that:

  • Both repositories can be cloned in one step with git clone --recurse-submodules
  • The appropriate commit from the resources repository will be versioned with this repository, so examples are guaranteed to work at any point in the project history.
@sketchpunk
Copy link
Contributor

Thats something I was going to do in the next version of ossos, but hopefully have a set of models I made myself so I dont need to worry about copyrights & whatnot.

@trusktr
Copy link

trusktr commented Apr 25, 2024

I think you can still make it a submodule regardless (put a disclaimer in the README about copyrights if needed).

I made a PR for ossos_next:

@trusktr
Copy link

trusktr commented Apr 25, 2024

The ossos_next branch now includes this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants