Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[r] Replace tiledb-r with libtiledbsoma in the R API (parent task) #2406

Open
johnkerl opened this issue Apr 8, 2024 · 0 comments · May be fixed by #3644
Open

[r] Replace tiledb-r with libtiledbsoma in the R API (parent task) #2406

johnkerl opened this issue Apr 8, 2024 · 0 comments · May be fixed by #3644

Comments

@johnkerl
Copy link
Member

johnkerl commented Apr 8, 2024

This is a sibling of #1632. Its sole job is to link-track, at the GitHub Issues level, smaller issues which will be split out as individual GitHub Issues.

Some sequencings:

Status quo and to-do items as of 2025-02-03:

  • Many tiledbsoma-r unit-test cases call into tiledb-r and should not.
  • The persistent underlying array handle opened at soma open and closed at soma close is a tiledb-r handle. These need to go away.
  • All the calls into libtiledbsoma pass in URI and context, doing open-use-close.
    • These libtiledbsoma handles need to be opened persistently as soma array open and closed at soma array close.
    • All the calls into libtiledbsoma need to then be modified to take in an open handle.
    • [r] Use libtiledbsoma for array handles #3061
  • This will require passing around SOMATileDBContext without breaking unit-test cases.
@johnkerl johnkerl self-assigned this Sep 24, 2024
@johnkerl johnkerl changed the title [r] Use new C++ bindings in R API (parent task) [r] Use new C++ bindings in R API, and remove tiledb-r dependency (parent task) Sep 24, 2024
@johnkerl johnkerl changed the title [r] Use new C++ bindings in R API, and remove tiledb-r dependency (parent task) [r] Replace tiledb-r with libtiledbsoma in the R API (parent task) Sep 24, 2024
mojaveazure added a commit that referenced this issue Feb 11, 2025
Remove an unused custom class as part of replacing `TileDBObject` with a
new SOMA base-object class that is not reliant on tiledb-r

[SC-63206](https://app.shortcut.com/tiledb-inc/story/63206)

continues work for #2406

Note: this PR is not going into `main`, but into a separate branch to
accumulate all of these little PRs before filing the larger one to
remove tiledb-r
mojaveazure added a commit that referenced this issue Feb 11, 2025
Remove an unused custom class as part of replacing `TileDBObject` with a
new SOMA base-object class that is not reliant on tiledb-r

[SC-63206](https://app.shortcut.com/tiledb-inc/story/63206)

continues work for #2406
mojaveazure added a commit that referenced this issue Feb 12, 2025
Remove an unused custom class as part of replacing `TileDBObject` with a
new SOMA base-object class that is not reliant on tiledb-r

[SC-63206](https://app.shortcut.com/tiledb-inc/story/63206)

continues work for #2406
mojaveazure added a commit that referenced this issue Feb 26, 2025
Remove an unused custom class as part of replacing `TileDBObject` with a
new SOMA base-object class that is not reliant on tiledb-r

[SC-63206](https://app.shortcut.com/tiledb-inc/story/63206)

continues work for #2406
mojaveazure added a commit that referenced this issue Mar 11, 2025
Remove an unused custom class as part of replacing `TileDBObject` with a
new SOMA base-object class that is not reliant on tiledb-r

[SC-63206](https://app.shortcut.com/tiledb-inc/story/63206)

continues work for #2406
mojaveazure added a commit that referenced this issue Mar 11, 2025
Replace tiledb-r with SOMA for test helper function to create an empty
sparse nd-array

[SC-64301](https://app.shortcut.com/tiledb-inc/story/64301)

continues work for #2406
mojaveazure added a commit that referenced this issue Mar 13, 2025
Replace the various tiledb-r wrapper base classes with new and expanded
SOMA base classes:

 - `TileDBObject` replaced by new `SOMAObject`
 - `TileDBArray` replaced by expanded `SOMAArrayBase`
 - `TileDBGroup` replaced by expanded `SOMACollectionBase`

[SC-64345](https://app.shortcut.com/tiledb-inc/story/64345)

continues work for #2406
mojaveazure added a commit that referenced this issue Mar 13, 2025
Replace `tiledb::is.sparse()` and `tiledb::allows_dups()` with new
R/Rcpp functions in tiledbsoma-r

  - `tiledb::is.sparse()` is replaced by `c_is_sparse()` and exposed as
  `SOMAArrayBase$is_sparse()`
  - `tiledb::allows_dups()` is replaced with `c_allows_dups()` and
  exposed as `SOMAArrayBase$allows_duplicates()`

[SC-64424](https://app.shortcut.com/tiledb-inc/story/64424)

continues work for #2406
mojaveazure added a commit that referenced this issue Mar 13, 2025
Replace `tiledb::is.sparse()` and `tiledb::allows_dups()` with new
R/Rcpp functions in tiledbsoma-r

  - `tiledb::is.sparse()` is replaced by `c_is_sparse()` and exposed as
  `SOMAArrayBase$is_sparse()`
  - `tiledb::allows_dups()` is replaced with `c_allows_dups()` and
  exposed as `SOMAArrayBase$allows_duplicates()`

[SC-64424](https://app.shortcut.com/tiledb-inc/story/64424)

continues work for #2406
mojaveazure added a commit that referenced this issue Mar 21, 2025
Replace `TileDBArray$attributes()` with new
`SOMAArrayBase$attributes()`; this method uses a libtiledbsoma/Rcpp
function rather than `tiledb::attrs()` and returns a named list instead
of a tiledb-r wrapper around external pointers

[SC-64814](https://app.shortcut.com/tiledb-inc/story/64814)

continues work for #2406
mojaveazure added a commit that referenced this issue Mar 21, 2025
…3834)

Replace `TileDBArray$attributes()` with new
`SOMAArrayBase$attributes()`; this method uses a libtiledbsoma/Rcpp
function rather than `tiledb::attrs()` and returns a named list instead
of a tiledb-r wrapper around external pointers

[SC-64814](https://app.shortcut.com/tiledb-inc/story/64814)

continues work for #2406
mojaveazure added a commit that referenced this issue Mar 26, 2025
Remove an unused custom class as part of replacing `TileDBObject` with a
new SOMA base-object class that is not reliant on tiledb-r

[SC-63206](https://app.shortcut.com/tiledb-inc/story/63206)

continues work for #2406
mojaveazure added a commit that referenced this issue Mar 26, 2025
Replace `tiledb::is.sparse()` and `tiledb::allows_dups()` with new
R/Rcpp functions in tiledbsoma-r

  - `tiledb::is.sparse()` is replaced by `c_is_sparse()` and exposed as
  `SOMAArrayBase$is_sparse()`
  - `tiledb::allows_dups()` is replaced with `c_allows_dups()` and
  exposed as `SOMAArrayBase$allows_duplicates()`

[SC-64424](https://app.shortcut.com/tiledb-inc/story/64424)

continues work for #2406
mojaveazure added a commit that referenced this issue Mar 26, 2025
…3834)

Replace `TileDBArray$attributes()` with new
`SOMAArrayBase$attributes()`; this method uses a libtiledbsoma/Rcpp
function rather than `tiledb::attrs()` and returns a named list instead
of a tiledb-r wrapper around external pointers

[SC-64814](https://app.shortcut.com/tiledb-inc/story/64814)

continues work for #2406
mojaveazure added a commit that referenced this issue Mar 26, 2025
Replace schema filter checking with new libtiledbsoma/Rcpp
`c_schema_fitlers()` function to return a named list of schema fitlers

[SC-64998](https://app.shortcut.com/tiledb-inc/story/64998)

continues work for #2406
mojaveazure added a commit that referenced this issue Mar 26, 2025
Replace calls to `tiledb::attrs()` with `$attributes()` accessor

[SC-64999](https://app.shortcut.com/tiledb-inc/story/64999)

continues work for #2406
mojaveazure added a commit that referenced this issue Mar 26, 2025
Replace calls to `tiledb::domain()` and other domain accessors with
libtiledbsom/Rcpp `c_domain()`

[SC-65000](https://app.shortcut.com/tiledb-inc/story/65000)

continues work for #2406
mojaveazure added a commit that referenced this issue Mar 26, 2025
Replace calls to `tiledb::attrs()` with `$attributes()` accessor

[SC-64999](https://app.shortcut.com/tiledb-inc/story/64999)

continues work for #2406
mojaveazure added a commit that referenced this issue Mar 26, 2025
Replace tiledb-r enum accessors with new libtiledb/Rcpp accessors

[SC-65002](https://app.shortcut.com/tiledb-inc/story/65002)

continues work for #2406
mojaveazure added a commit that referenced this issue Mar 28, 2025
Replace schema filter checking with new libtiledbsoma/Rcpp
`c_schema_fitlers()` function to return a named list of schema fitlers

[SC-64998](https://app.shortcut.com/tiledb-inc/story/64998)

continues work for #2406
mojaveazure added a commit that referenced this issue Mar 28, 2025
Replace calls to `tiledb::domain()` and other domain accessors with
libtiledbsom/Rcpp `c_domain()`

[SC-65000](https://app.shortcut.com/tiledb-inc/story/65000)

continues work for #2406
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants