Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

got.stream binary files from S3 undefined when promise resolves #2372

Open
jessejamesblack opened this issue Aug 16, 2024 · 0 comments
Open

Comments

@jessejamesblack
Copy link

Hello, we are having an issue with getting binary files using got.stream when we resolve the promise the result is undefined. All other file types png, jpg, pdf, etc work. The version of got we are using is 11.8.2 I've also tried updgrading/downgrading and the same issue appears.

Example:

const stream = got.stream(s3presignedURL);
promises.push(fileType.fromStream(stream));

fileType is the npm package file-type and promises is a promise array that we push too.
When we resolve these promises if one of the files is a binary file the result is undefined. Is there something we are doing wrong here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant