Proxy agent usage with option `http2` set to true. #1715

3ldar · 2021-05-04T17:33:27Z

3ldar
May 4, 2021

Node.js version: v15.14.0
OS & version: Windows 10 Pro also tested in node:current container

Well, I couldn't know if it's a bug or an undocumented option. It ignores the proxy agent when you set http2: true in the options. Even if the request is made with HTTP 1.1 it doesn't care about the agent settings.

Code to reproduce

let result = await got("https://whatismyip.host/");
const $ = cheerio.load(result.body);
const ip = $("#ipv4address").text();
console.log("original ip ", IP); // this logs my current Ip

const agent = tunnel.httpsOverHttp({
                proxy: {
                    host: host, // host and port
                    port: port,
                    proxyAuth: 'a password' // did try with auth and without auth
                }
            });
 const headers = {
                'user-agent': userAgent.toString(),
                ...defaultHeaders,
                ...securityHeaders
 };
const jar = new CookieJar();
const result = await got("https://www.amazon.com/", {
                agent: {
                    https: agent,
                    http: agent
                },
                cookieJar: jar,
                timeout: 25000,
                headers,
                htttp2:true
            });          
const $ = cheerio.load(result.body);           
const ip = $("#ipv4address").text();
console.log(`Ip with proxy : ${currentProxy} => ${ip}`); // I expect a different IP here but get the same IP as before