Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace react-selectable dependency with something maintained #1528

Closed
1 task done
GuySartorelli opened this issue Dec 18, 2024 · 2 comments
Closed
1 task done

Replace react-selectable dependency with something maintained #1528

GuySartorelli opened this issue Dec 18, 2024 · 2 comments
Assignees

Comments

@GuySartorelli
Copy link
Member

GuySartorelli commented Dec 18, 2024

react-selectable looks like it may have been made specifically for asset-admin but is no longer being maintained.
It also has some strange coupling - e.g. see https://github.com/unclecheese/react-selectable/blob/802b1ec9ad1ef97fd241f48e612dd1b334b447b8/src/selectable-group.js#L126-L127

I recommend we replace it with https://www.npmjs.com/package/@air/react-drag-to-select

Acceptance Criteria

  • react-selectable is replaced with a maintained alternative

PRs

@emteknetnz
Copy link
Member

No changelog PR for this one - we have a broad "Several JavaScript dependencies have been updated, and a few have been replaced." in the 6.0.0 changelog already. I don't think this dep warrants its own mention because it's so specialized.

@GuySartorelli
Copy link
Member Author

PRs merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants