Codecov Report

Attention: Patch coverage is 84.21053% with 9 lines in your changes missing coverage. Please review.

Project coverage is 88.98%. Comparing base (acba120) to head (1552305).
Report is 8 commits behind head on master.

@@            Coverage Diff             @@
##           master    #3261      +/-   ##
==========================================
+ Coverage   88.77%   88.98%   +0.20%     
==========================================
  Files          85       86       +1     
  Lines       13448    13504      +56     
  Branches     1535     1560      +25     
==========================================
+ Hits        11939    12016      +77     
+ Misses       1509     1488      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Test added.

Hey @jcmartineztiempo, thanks!
I couldn't pause to understand why the last test wouldn't finish, but it seems to have been fixed in recent commits.

Also, sorry for the lack of infos or support, December is usually very hectic 😅

Hi @wellwelwel,

Yeah...the last test wouldn't finish due a sql syntax error in mysql 5.7. I'll look into it later.

Don't worry about support...it's my first ever pool request!!

Hi, @jcmartineztiempo, bringing this #3091 (comment) here:

Hi, when will it be merged and released?

Because of this, I figured that the work was not yet complete:

Yeah...the last test wouldn't finish due a sql syntax error in mysql 5.7. I'll look into it later.

Sorry for the miscommunication.

Could you rebase just to trigger the recent tests into your changes?

@sidorares, just a friendly ping: could you enable the following option in the repository settings?

• This will display a button that allows us to automatically rebase outdated branches without conflict and ensure that the test suite always runs through the latest version.

Hi,

just enabled.

Thanks

Hi,

just enabled.

Thanks

Hey @jcmartineztiempo, this point is for @sidorares in MySQL2 repository 🙋🏻‍♂️

@wellwelwel this is enabled now

@jcmartineztiempo, sorry for the long delay. I've checked the behavior from mysqljs and if the typings match.

A concern was about a possible unintentional breaking change if someone checks the return using instanceof, but since it's the wrong behavior, it makes sense not to consider it that way.

A suggestion before merging (to keep consistency), would be to move the PromisePoolNamespace method to lib/promise/ and create a new file for it (pool_cluster.js) 🙋🏻‍♂️

Hi @wellwelwel,

I just refactor the code to move PromisePoolNamespace to lib/promise/pool_cluster.js.

Thanks, @jcmartineztiempo (and welcome to the project contributors) 🚀

The fix is already available in 3.12.1-canary.be22202e version.

I've been holding the release for some time, because we depend on certain external factors. But you can follow the progress in #3377.