Merge cockroachdb#140684

craig[bot] · mgartner · craig[bot] · commit ecfb74b7ad75 · 2025-02-08T21:29:36.000Z
140684: opt: parameterize json-insert benchmark r=mgartner a=mgartner Follow-up from cockroachdb#135708. Epic: None Release note: None Co-authored-by: Marcus Gartner <marcus@cockroachlabs.com>
diff --git a/pkg/sql/opt/bench/bench_test.go b/pkg/sql/opt/bench/bench_test.go
@@ -534,8 +534,8 @@ var queries = [...]benchQuery{
 	},
 	{
 		name:    "json-insert",
-		query:   `INSERT INTO json_table(k, i, j) VALUES (1, 10, '{"a": "foo", "b": "bar", "c": [2, 3, "baz", true, false, null]}')`,
-		args:    []interface{}{},
+		query:   `INSERT INTO json_table(k, i, j) VALUES ($1, $2, $3)`,
+		args:    []interface{}{1, 10, `'{"a": "foo", "b": "bar", "c": [2, 3, "baz", true, false, null]}'`},
 		cleanup: "TRUNCATE TABLE json_table",
 	},
 	{

Original file line number	Diff line number	Diff line change
`@@ -534,8 +534,8 @@ var queries = [...]benchQuery{`
`534`	`534`	`},`
`535`	`535`	`{`
`536`	`536`	`name: "json-insert",`
`537`		- query: `INSERT INTO json_table(k, i, j) VALUES (1, 10, '{"a": "foo", "b": "bar", "c": [2, 3, "baz", true, false, null]}')`,
`538`		`- args: []interface{}{},`
	`537`	+ query: `INSERT INTO json_table(k, i, j) VALUES ($1, $2, $3)`,
	`538`	+ args: []interface{}{1, 10, `'{"a": "foo", "b": "bar", "c": [2, 3, "baz", true, false, null]}'`},
`539`	`539`	`cleanup: "TRUNCATE TABLE json_table",`
`540`	`540`	`},`
`541`	`541`	`{`