Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let's require symbol keys in hashes #33

Closed
wasnotrice opened this issue May 28, 2012 · 4 comments
Closed

Let's require symbol keys in hashes #33

wasnotrice opened this issue May 28, 2012 · 4 comments

Comments

@wasnotrice
Copy link
Member

Currently, we have some places where we use the facets method stringify_keys! (e.g. Shoes::App). I would prefer to see us use only symbol keys in hashes, like current versions of Shoes. Less overhead, easier to reason about, than permitting both strings and symbols.

See shoes/brown_shoes#5
@alindeman
Copy link
Contributor

👍

@alindeman
Copy link
Contributor

Recommend merging #29 before starting on this (or rebasing any fix on top of it)

@wasnotrice
Copy link
Member Author

#29 has been merged!

@steveklabnik
Copy link
Member

👍, symbol keys are where it's at.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wasnotrice @steveklabnik @alindeman