Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates Multi-Arch resources to be ClusterScoped #1807

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Updates Multi-Arch resources to be ClusterScoped #1807

wants to merge 2 commits into from
+18 −6

Conversation

apoorvajagtap
Copy link
Member

Changes

This PR includes following changes:

  • Replaces the Role references to ClusterRole references. Updates the doc to create the roleBindings accordingly.
  • In kind cluster, there doesn't seem to have pipeline SA in all the namesapces, so, another commit makes SERVICE_ACCOUNT configurable while applying the roleBinding.

Fixes #1756

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

NONE

@openshift-ci openshift-ci bot added the release-note-none Label for when a PR does not need a release note label Feb 22, 2025
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 22, 2025
@apoorvajagtap apoorvajagtap mentioned this pull request Feb 22, 2025
Open
1 task
@apoorvajagtap apoorvajagtap force-pushed the issue_1756 branch 2 times, most recently from ddd625d to b559699 Compare February 22, 2025 17:50
@apoorvajagtap
Copy link
Member Author

@adambkaplan let me know if we prefer to keep the commits separate or squash them. I'll sign off the commits accordingly.

@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.16.0 milestone Feb 24, 2025
SaschaSchwarze0
SaschaSchwarze0 approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaschaSchwarze0 SaschaSchwarze0 SaschaSchwarze0 approved these changes

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

@HeavyWombat HeavyWombat Awaiting requested review from HeavyWombat

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note-none Label for when a PR does not need a release note size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Shipwright Overview
Status: No status
Milestone
release-v0.16.0
Development

Successfully merging this pull request may close these issues.

[BUG] Multi-arch ClusterBuildStrategy has Namespace Scoped Resources
2 participants
@apoorvajagtap @SaschaSchwarze0