From e5564bcdc69aa27ba34be5d3394ccabc0b4de7a0 Mon Sep 17 00:00:00 2001 From: alphashaw Date: Fri, 26 Aug 2022 10:12:22 +0000 Subject: [PATCH] update bad parsePrecedence return value --- api/v1alpha1/virtualservicemerge_types.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/api/v1alpha1/virtualservicemerge_types.go b/api/v1alpha1/virtualservicemerge_types.go index 61ae570..67beaa0 100644 --- a/api/v1alpha1/virtualservicemerge_types.go +++ b/api/v1alpha1/virtualservicemerge_types.go @@ -185,14 +185,14 @@ func sanitizeRoutes(ctx reconciler.Context, routes []*v1alpha3.HTTPRoute) []*v1a func parsePrecedence(ctx reconciler.Context, name string) (string, int, bool) { parts := strings.Split(name, "-") - if len(parts) == 1 { + if len(parts) <= 1 { return name, 0, false } precedenceStr := parts[len(parts)-1] precedence, err := strconv.ParseInt(precedenceStr, 10, 64) if err != nil { - ctx.Logger().Info("No precedence for route; defaulting to 0", "route", name) - return precedenceStr, 0, false + ctx.Logger().Info("No precedence for route. Defaulting to 0", "route", name) + return name, 0, false } return strings.Join(parts[:len(parts)-1], "-"), int(precedence), true }