Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add language pack for MDX #342

Closed
trevordmiller opened this issue Sep 3, 2018 · 7 comments
Closed

Add language pack for MDX #342

trevordmiller opened this issue Sep 3, 2018 · 7 comments

Comments

@trevordmiller
Copy link

MDX is a new language that combines Markdown and JSX. It's becoming very popular in the JavaScript + React community lately. Per the discussion in mdx-js/mdx#119, vim-mdx-js is going to be the main MDX language pack for Vim. Could it be added to vim-polyglot for .mdx files?

cc: @jxnblk

@trevordmiller
Copy link
Author

Although for this to be in vim-polyglot, @jxnblk should probably remove https://github.com/jxnblk/vim-mdx-js/blob/4bf61b0728a387a241b48691f5b5adf0b03e1ea2/ftdetect/mdx.vim#L8, so only .mdx files are detected as markdown.mdx filetype.

@sheerun sheerun closed this as completed in b69fbad Mar 4, 2019
@sheerun
Copy link
Owner

sheerun commented Mar 4, 2019

For now I've overwritten ftdetect part

@trevordmiller
Copy link
Author

Awesome! I’m looking forward to this being released. cc @jxnblk

@sheerun
Copy link
Owner

sheerun commented Mar 4, 2019

This is released, just update your plugins

@trevordmiller
Copy link
Author

@sheerun I removed vim-mdx-js from my plugins, upgraded my vim-polyglot plugin, restarted Vim, and now .mdx files are not being recognized correctly. :set filetype? in an .mdx file shows filetype=conf.

@sheerun sheerun reopened this Mar 4, 2019
@sheerun
Copy link
Owner

sheerun commented Mar 4, 2019

Yes I did something stupid, but it should work now. Also upstream accepted my PR with fixed ftdetect vim-polyglot uses this plugin unmodified

@sheerun sheerun closed this as completed Mar 4, 2019
@trevordmiller
Copy link
Author

Works great! Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants