Skip to content

Commit f8ee41b

Browse files
authored
ci: Fix workflow events (#77)
This was found by auditing workflows based on research published here: https://github.com/joeyparrish/workflow-cheat-sheet The research was prompted by a workflow bug in Shaka Streamer
1 parent b6ad1b5 commit f8ee41b

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

.github/workflows/release-please.yml

+8-1
Original file line numberDiff line numberDiff line change
@@ -17,21 +17,28 @@ jobs:
1717

1818
# The logic below handles npm publication. Each step is conditional on a
1919
# release having been created by someone merging the release PR.
20-
- uses: actions/checkout@v2
20+
- uses: actions/checkout@v4
21+
with:
22+
ref: refs/tags/${{ steps.release.outputs.tag_name }}
2123
if: ${{ steps.release.outputs.release_created }}
24+
2225
- uses: actions/setup-node@v1
2326
with:
2427
node-version: 12
2528
registry-url: 'https://registry.npmjs.org'
2629
if: ${{ steps.release.outputs.release_created }}
30+
2731
- run: npm ci
2832
if: ${{ steps.release.outputs.release_created }}
33+
2934
- run: npm publish
3035
env:
3136
NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN}}
3237
if: ${{ steps.release.outputs.release_created }}
38+
3339
- run: npm pack
3440
if: ${{ steps.release.outputs.release_created }}
41+
3542
- uses: svenstaro/upload-release-action@483c1e56f95e88835747b1c7c60581215016cbf2
3643
with:
3744
repo_token: ${{ secrets.GITHUB_TOKEN }}

0 commit comments

Comments
 (0)