CI with GitHub Actions

 - adds github actions build definition
 - fixes ConstantsSetBuilderSpecTest issue causing test to randomly fail
 - fixes logic-based tests with dynamic predicates and functions

Author: anskarl

.github/workflows/main.yml

@@ -0,0 +1,53 @@
+name: build
+
+on: [push, pull_request]
+
+jobs:
+  build:
+
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v2
+        with:
+          fetch-depth: 1
+      - name: Fetch example data
+        shell: bash
+        run: git submodule update --init
+      - name: Set up JDK 1.8
+        uses: actions/setup-java@v1
+        with:
+          java-version: 1.8
+      - name: Install lp_solve
+        run: sudo apt update && sudo apt install -y bash lp-solve wget zip unzip && sudo rm -rf /var/lib/apt/lists/*
+      - name: Install lp_solve java
+        run: (cd /tmp && wget https://sourceforge.net/projects/lpsolve/files/lpsolve/5.5.2.5/lp_solve_5.5.2.5_java.zip && unzip lp_solve_5.5.2.5_java.zip && sudo cp lp_solve_5.5_java/lib/ux64/liblpsolve55j.so /usr/lib/lp_solve && sudo ldconfig && sudo rm -rf /tmp/lp_solve_5.5_java && rm /tmp/lp_solve_5.5.2.5_java.zip)
+      - name: Docker login
+        uses: azure/docker-login@v1
+        with:
+          login-server: 'docker.pkg.github.com'
+          username: ${GITHUB_ACTOR}
+          password: ${{ secrets.GITHUB_TOKEN }}
+      - name: Cache SBT ivy cache
+        uses: actions/cache@v1
+        with:
+          path: ~/.ivy2/cache
+          key: ${{ runner.os }}-sbt-ivy-cache-${{ hashFiles('**/build.sbt') }}
+      - name: Cache SBT
+        uses: actions/cache@v1
+        with:
+          path: ~/.sbt
+          key: ${{ runner.os }}-sbt-${{ hashFiles('**/build.sbt') }}
+      - name: Build for Scala 2.12
+        run: sbt ++2.12.10 clean compile
+      - name: Run Tests
+        run: sbt ++2.12.10 test
+      - name: Create Docker Image
+        run: sbt ++2.12.10 docker
+      - name: Push docker images
+        if: github.event_name != 'pull_request'
+        run: sbt ++2.12.10 dockerPush
+    env:
+      _JAVA_OPTIONS: "-Xms512m -Xmx4g"
+      REPOSITORY_OWNER: ${{ github.repository }}
+      LD_LIBRARY_PATH: "/usr/lib/lp_solve"

README.md

@@ -1,3 +1,5 @@
+[![Build](https://github.com/anskarl/lomrf/workflows/build/badge.svg?branch=master)](https://github.com/anskarl/lomrf/actions)
+
 <pre>
     o                        o     o   o         o
     |             o          |     |\ /|         | /

project/Dependencies.scala

@@ -32,7 +32,6 @@ object Dependencies {
     final val JANSI = "1.11"
 
     final val ScalaTest = "3.0.5"
-    final val ScalaCheck = "1.14.1"
 
     final val Trove4j = "3.0.3" // todo upgrade to 3.1
     final val JTS = "1.14.0"
@@ -62,8 +61,7 @@ object Dependencies {
 
   // ScalaTest got Unit testing
   lazy val Testing = Seq(
-    "org.scalatest" %% "scalatest" % v.ScalaTest % "test",
-    "org.scalacheck" %% "scalacheck" % v.ScalaCheck % "test"
+    "org.scalatest" %% "scalatest" % v.ScalaTest % "test"
   )
 
   lazy val Utils = Seq(

project/LoMRFBuild.scala

@@ -166,7 +166,7 @@ object LoMRFBuild extends AutoPlugin {
       scalaBinaryVersion.value match {
 
         case "2.11" =>
-          // Scala compiler settings for Scala 2.12.x
+          // Scala compiler settings for Scala 2.11.x
           Seq(
             "-deprecation",       // Emit warning and location for usages of deprecated APIs.
             "-unchecked",         // Enable additional warnings where generated code depends on assumptions.
@@ -213,43 +213,49 @@ object LoMRFBuild extends AutoPlugin {
       new Dockerfile {
 
         // Base image
-        from("frolvlad/alpine-oraclejdk8")
+        from("openjdk:11-slim")
 
         // Copy to docker
         copy(universalBuildDir, targetDir)
 
         // Add Bash support
-        runRaw("apk add --update bash")
 
-        // clean up package cache to reduce space
-        runRaw("rm -rf /var/cache/apk/*")
+        runRaw("apt update && apt install -y bash lp-solve wget zip unzip && rm -rf /var/lib/apt/lists/*")
 
-        // Make consumer script executable
-        runRaw(s"chmod +x $targetDir/bin/lomrf")
+        runRaw (
+          "cd /tmp && " +
+            "wget https://sourceforge.net/projects/lpsolve/files/lpsolve/5.5.2.5/lp_solve_5.5.2.5_java.zip && " +
+            "unzip lp_solve_5.5.2.5_java.zip && " +
+            "cp lp_solve_5.5_java/lib/ux64/liblpsolve55j.so /usr/lib/lp_solve && " +
+            "ldconfig && " +
+            "rm -rf /tmp/lp_solve_5.5_java && " +
+            "rm /tmp/lp_solve_5.5.2.5_java.zip"
+          )
 
+        env("LD_LIBRARY_PATH", "/usr/lib/lp_solve")
 
+        runRaw(s"chmod +x $targetDir/bin/lomrf")
         runRaw("mkdir /data")
-        // set working dir
         workDir(s"/data")
-
         volume("/data")
-
         entryPoint(s"$targetDir/bin/lomrf")
       }
     },
 
     imageNames in docker := {
-      val localTag = ImageName(s"${name.value.toLowerCase}:latest")
-
-      // Set a name with a tag that contains the project version.
-      val versionTag = ImageName(s"${organization.value}/${name.value.toLowerCase}:${version.value}")
-
-      // Set a name with the latest tag, only for stable versions.
-      if(!isSnapshot.value) {
-        val latestTag = ImageName(s"${organization.value}/${name.value.toLowerCase}:latest")
-        Seq(versionTag, latestTag, localTag)
-      }
-      else Seq(versionTag, localTag)
+      val tags =
+        sys.env.get("REPOSITORY_OWNER") match {
+          case Some(repositoryOwner) =>
+            Seq(
+              s"docker.pkg.github.com/${repositoryOwner.toLowerCase}/lomrf:${version.value}",
+              s"docker.pkg.github.com/${repositoryOwner.toLowerCase}/lomrf:latest")
+          case None =>
+            Seq(
+              s"lomrf:${version.value}",
+              s"lomrf:latest")
+        }
+
+      tags.map(tag => ImageName(tag))
 
     },
 

src/test/scala/lomrf/logic/compile/PredicateCompletionSpecTest.scala

@@ -220,15 +220,15 @@ final class PredicateCompletionSpecTest extends FunSpec with Matchers {
     val expected = Set(
       parser.parseWeightedFormula(
         """
-          | (Exist t1 Happens(inactive(x),t) ^ !Happens(walking(y),t1) ^ lessThan(t1,t)) v
+          | (Exist t1 Happens(inactive(x),t) ^ !Happens(walking(y),t1) ^ LessThan(t1,t)) v
           | (Happens(active(x),t) ^ Happens(inactive(y),t)) =>
           | HoldsAt(meet(x, y), t++).
         """.stripMargin
       ),
       parser.parseWeightedFormula(
         """
           | !HoldsAt(meet(x, y),t) ^
-          | !((Exist t1 Happens(inactive(x),t) ^ !Happens(walking(y),t1) ^ lessThan(t1,t)) v
+          | !((Exist t1 Happens(inactive(x),t) ^ !Happens(walking(y),t1) ^ LessThan(t1,t)) v
           | (Happens(active(x),t) ^ Happens(inactive(y),t))) =>
           | !HoldsAt(meet(x, y),t++)
         """.stripMargin

src/test/scala/lomrf/logic/parser/KBParserSpecTest.scala

@@ -501,7 +501,7 @@ final class KBParserSpecTest extends FunSpec with Matchers {
       parsed.functions.size shouldEqual 0
     }
 
-    val dynamicFormula7 = "HoldsAt(f, t) <=> substr(Meet, f)."
+    val dynamicFormula7 = "HoldsAt(f, t) <=> Substr(Meet, f)."
     it(s"$dynamicFormula7 should be a valid FOL sentence") {
       val parsed = parser.parseLogicalSentence(dynamicFormula7)
 

src/test/scala/lomrf/mln/model/builders/ConstantsSetBuilderSpecTest.scala

@@ -20,16 +20,16 @@
 
 package lomrf.mln.model.builders
 
-import org.scalacheck.Gen
-import org.scalatest.prop.PropertyChecks
-import org.scalatest.{FunSpec, Matchers}
+import org.scalatest.{ FunSpec, Matchers }
+
+import scala.util.Random
 
 /**
   * A series of specification test for constants set builder.
   *
   * @see [[lomrf.mln.model.builders.ConstantsSetBuilder]]
   */
-final class ConstantsSetBuilderSpecTest extends FunSpec with Matchers with PropertyChecks {
+final class ConstantsSetBuilderSpecTest extends FunSpec with Matchers {
 
   describe("An empty builder") {
     val builder = ConstantsSetBuilder()
@@ -83,10 +83,8 @@ final class ConstantsSetBuilderSpecTest extends FunSpec with Matchers with Prope
 
   describe("A builder holding a more constant symbols") {
 
-    var constants = List.empty[String]
-    forAll(Gen.alphaNumStr) { symbol: String =>
-      constants = symbol :: constants
-    }
+    val constants =
+      for (idx <- 1 to 10) yield s"C${idx}" + Random.alphanumeric.take(5).toString()
 
     val builder = ConstantsSetBuilder(constants)