Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question. Why Serilog.Sinks.Debug causes downloading of System.Diagnostics.Debug NuGet package when my project targets .NET Framework 4.7.1? #6

Closed
ches151 opened this issue Mar 27, 2018 · 3 comments
Closed

Question. Why Serilog.Sinks.Debug causes downloading of System.Diagnostics.Debug NuGet package when my project targets .NET Framework 4.7.1? #6

ches151 opened this issue Mar 27, 2018 · 3 comments

Comments

@ches151
Copy link

ches151 commented Mar 27, 2018

Why Serilog.Sinks.Debug causes downloading of System.Diagnostics.Debug NuGet package when my project targets .NET Framework 4.7.1?
Isn't System.Diagnostics.Debug a part of .NET Framework 4.7.1?
@Numpsy
Copy link
Member

Numpsy commented Nov 3, 2020

I don't think it should need to reference the System.Diagnostics.Debug package for any of the target frameworks it builds with other than netstandard1.0 (though maybe netstandard1.0 isn't much needed going forwards?) - it should be built in for both full .NET framework and netstandard2.0

@Numpsy Numpsy mentioned this issue Dec 13, 2020
Merged
@Numpsy
Copy link
Member

Numpsy commented Jan 14, 2021

this should be fixed in the current preview builds

@nblumhardt
Copy link
Member

Coming shortly in #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nblumhardt @ches151 @Numpsy