Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLNP-6534] fix: resolve FlatList-related error on Metro 0.81.3 #231

Merged
merged 2 commits into from
Apr 1, 2025

Conversation

OnestarLee
Copy link
Collaborator

@OnestarLee OnestarLee commented Apr 1, 2025

External Contributions

This project is not yet set up to accept pull requests from external contributors.

If you have a pull request that you believe should be accepted, please contact
the Developer Relations team [email protected] with details
and we'll evaluate if we can setup a CLA to allow for the contribution.

For Internal Contributors

[CLNP-6534](https://sendbird.atlassian.net/browse/CLNP-6534)

Description Of Changes

  • Resolved FlatList-related error on Metro 0.81.3
  • Both FlatListBidirectional and BidirectionalProps have been removed as they were unused.

Types Of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply_

  • Bugfix
  • New feature
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance (ex) Prettier)
  • Build configuration
  • Improvement (refactor code)
  • Test

@OnestarLee OnestarLee changed the title fix: resolve FlatList-related error on Metro 0.81.3 [CLNP-6534] fix: resolve FlatList-related error on Metro 0.81.3 Apr 1, 2025
@OnestarLee OnestarLee requested review from Copilot and bang9 April 1, 2025 07:53
@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 11.53%. Comparing base (119150f) to head (4d8d88f).

Files with missing lines Patch % Lines
...e/src/components/ChatFlatList/FlatListInternal.tsx 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main     #231    +/-   ##
========================================
  Coverage   11.53%   11.53%            
========================================
  Files         357      357            
  Lines        8463     8460     -3     
  Branches     2386     2248   -138     
========================================
  Hits          976      976            
- Misses       7412     7483    +71     
+ Partials       75        1    -74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a FlatList-related error on Metro 0.81.3 by adjusting how the FlatList component is selected based on platform conditions. The key changes include:

  • Removing unused type imports and type definitions.
  • Refactoring the getFlatList function into a direct, variable-assignment approach.
  • Exporting the selected FlatList component directly.

Copy link
Collaborator

@bang9 bang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@OnestarLee OnestarLee added this pull request to the merge queue Apr 1, 2025
Merged via the queue into main with commit 6c19b24 Apr 1, 2025
7 checks passed
@OnestarLee OnestarLee deleted the fix/support-metro-0.81.3 branch April 1, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants