-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruby scanning not working in JS version of Semgrep VSCode Extension #138
Comments
Thanks for the report! When we released LSP.js we did have some issues with Ruby, so we have a good idea of what this is. Let me see if there were any regressions |
looks like this is indeed a regression, will add to my todos to get to at some point |
Ok, it's on our roadmap for sometime in the next month or two, as we have a major refactor we need to do before we can get to this |
This should be fixed in 1.79.0 most likely! |
Could you confirm this should be fix @ajbt200128? I retested with the latest version of the extension, I'm not seeing the error anymore, but I am also not seeing the expected result. |
Let me see if I can repro |
yea looks like this is a bug, will add it to the backlog, but not sure if we will be able to get to it anytime soon |
Detection of issues in Ruby files is not working when running the JS version of the extension. This occurs both when running the extension on Mac in JS mode and when using the extension on Windows.
Extension version: v1.7.1
Expected behaviour: Scanning a Ruby file should detect the same issues in JS and non-JS mode
Current Behavior: No issues are being detected in Ruby files when running in JS mode
How to reproduce
Create a file index.rb with the following content
When running in non-JS mode, an issue is detected on line 13 (ruby.aws-lambda.security.tainted-sql-string.tainted-sql-string).
When switching to JS mode using the
Semgrep: Use JS
extension setting or when running on Windows, no issues are being detected.In the Semgrep Output window, I can see an error that I expect is causing the issue
Testing on different Ruby files with different rulesets, still results in this same error.
The text was updated successfully, but these errors were encountered: