Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat): support for zarr-python>=3 #1726

Draft
wants to merge 84 commits into
base: main
Choose a base branch
from
Draft

(feat): support for zarr-python>=3 #1726

wants to merge 84 commits into from

Conversation

ilan-gold
Copy link
Contributor

@ilan-gold ilan-gold commented Oct 21, 2024 •
edited by flying-sheep
Loading

@codecov Codecov
Copy link

codecov bot commented Oct 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 78.94737% with 32 lines in your changes missing coverage. Please review.

Project coverage is 83.54%. Comparing base (3a08892) to head (e13de5a).

Files with missing lines Patch % Lines
src/anndata/_io/specs/methods.py 79.03% 13 Missing ⚠️
src/anndata/tests/helpers.py 60.00% 6 Missing ⚠️
src/anndata/compat/__init__.py 69.23% 4 Missing ⚠️
src/anndata/_core/anndata.py 33.33% 2 Missing ⚠️
src/anndata/_io/zarr.py 83.33% 2 Missing ⚠️
src/anndata/_settings.py 80.00% 2 Missing ⚠️
src/anndata/_core/sparse_dataset.py 93.33% 1 Missing ⚠️
src/anndata/_io/h5ad.py 66.66% 1 Missing ⚠️
src/anndata/experimental/merge.py 92.30% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1726      +/-   ##
==========================================
- Coverage   86.11%   83.54%   -2.57%     
==========================================
  Files          40       40              
  Lines        6242     6322      +80     
==========================================
- Hits         5375     5282      -93     
- Misses        867     1040     +173
Files with missing lines Coverage Δ
src/anndata/_io/specs/registry.py 94.44% <100.00%> (-0.48%) ⬇️
src/anndata/_io/utils.py 76.15% <ø> (ø)
src/anndata/abc.py 100.00% <ø> (ø)
src/anndata/_core/sparse_dataset.py 92.05% <93.33%> (-0.09%) ⬇️
src/anndata/_io/h5ad.py 92.27% <66.66%> (-0.42%) ⬇️
src/anndata/experimental/merge.py 87.20% <92.30%> (-0.24%) ⬇️
src/anndata/_core/anndata.py 82.42% <33.33%> (-0.20%) ⬇️
src/anndata/_io/zarr.py 82.55% <83.33%> (-0.99%) ⬇️
src/anndata/_settings.py 93.79% <80.00%> (+0.26%) ⬆️
src/anndata/compat/__init__.py 79.47% <69.23%> (-3.64%) ⬇️
... and 2 more

... and 4 files with indirect coverage changes

@ilan-gold ilan-gold mentioned this pull request Nov 5, 2024
Open
3 tasks
@ilan-gold
Copy link
Contributor Author

ilan-gold commented Nov 18, 2024 •
edited
Loading

blockers:

borderline blocker, TBD:

non-blockers, but would be nice to fix:

v3 file-format blockers:

@falexwolf falexwolf mentioned this pull request Dec 9, 2024
Open
@flying-sheep flying-sheep mentioned this pull request Jan 10, 2025
Open
3 tasks
@flying-sheep flying-sheep added this to the 0.12.0 milestone Jan 10, 2025
@LDeakin LDeakin mentioned this pull request Jan 30, 2025
Closed
@ilan-gold ilan-gold mentioned this pull request Feb 4, 2025
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip-gpu-ci
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.

Support zarr v3
2 participants
@ilan-gold @flying-sheep