Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Circles in "think" bubble's tail aren't closed in Firefox #1116

Open
adroitwhiz opened this issue Mar 6, 2024 · 0 comments · May be fixed by #1117
Open

Circles in "think" bubble's tail aren't closed in Firefox #1116

adroitwhiz opened this issue Mar 6, 2024 · 0 comments · May be fixed by #1117

Comments

@adroitwhiz
Copy link
Contributor

Expected Behavior

The two circles in a "think" bubble's tail should appear as completely closed circles.

Actual Behavior

In Firefox, there's a small gap in the stroke around the circles, likely due to floating-point error making ctx.arc not complete a full circle:
image

Steps to Reproduce

  1. Open Scratch in Firefox
  2. Click the "think (Hmm...)" block
  3. Enter full-screen mode and look at the bubble

System Details

Firefox 122 on Fedora

Screenshots
See above
@adroitwhiz adroitwhiz linked a pull request Mar 6, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Properly close think bubble's circles adroitwhiz/scratch-render
1 participant
@adroitwhiz