Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor grid dots persist at wrong zoom level #6106

Open
benjiwheeler opened this issue Aug 19, 2020 · 1 comment · May be fixed by #9557
Open

Editor grid dots persist at wrong zoom level #6106

benjiwheeler opened this issue Aug 19, 2020 · 1 comment · May be fixed by #9557

Comments

@benjiwheeler
Copy link
Contributor

benjiwheeler commented Aug 19, 2020

Expected Behavior

  1. in the editor, have two (or more) sprites in a project
  2. add blocks so that blocks are visible within each sprite
  3. zoom both sprites to the default zoom level
  4. click on sprite A and zoom way in, until the grid dots are large
  5. click on sprite B

expected:
6. grid dots are small and close together in sprite B, in keeping with the zoom level

Actual Behavior

  1. grid dots are large and far apart in sprite B, clashing with the zoom level

Related

See related change: #4542

We may need to update the zoom level when the sprite/backdrop selected changes.

@towerofnix
Copy link
Contributor

towerofnix commented Aug 19, 2020

I'm guessing this has to do with the setTimeout here - I figure whatever code is updating the grid dots is doing it in reaction to the workspace being loaded* rather than reacting to the metrics being updated.

* nb: take "loaded" lightly; I haven't actually investigated the relevant code. Point is, it's running before the setTimeout callback, ergo generating the grids on the previous zoom level rather than the zoom level set in that callback.

@BryceLTaylor BryceLTaylor added this to the Confirm Prioritization milestone Aug 20, 2020
@bruh-9000 bruh-9000 linked a pull request Apr 11, 2024 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants