Python 3.5 support

Author: elacuesta

.github/workflows/main.yml

@@ -30,7 +30,7 @@ jobs:
     runs-on: ubuntu-18.04
     strategy:
       matrix:
-        python-version: [3.6, 3.7, 3.8]
+        python-version: [3.5, 3.6, 3.7, 3.8]
 
     steps:
     - uses: actions/checkout@v2

README.md

@@ -8,7 +8,7 @@ to transparently interact with the [Crawlera Fetch API](https://scrapinghub.atla
 
 ## Requirements
 
-* Python 3.6+
+* Python 3.5+
 * Scrapy 1.6+
 
 

crawlera_fetch/middleware.py

@@ -119,7 +119,7 @@ def process_request(self, request: Request, spider: Spider) -> Optional[Request]
         request.headers.update(additional_headers)
 
         if scrapy.version_info < (2, 0, 0):
-            original_url_flag = f"original url: {request.url}"
+            original_url_flag = "original url: {}".format(request.url)
             if original_url_flag not in request.flags:
                 request.flags.append(original_url_flag)
 

setup.py

@@ -19,6 +19,7 @@
         "Development Status :: 1 - Planning",
         "License :: OSI Approved :: BSD License",
         "Programming Language :: Python",
+        "Programming Language :: Python :: 3.5",
         "Programming Language :: Python :: 3.6",
         "Programming Language :: Python :: 3.7",
         "Programming Language :: Python :: 3.8",
@@ -28,5 +29,6 @@
         "Topic :: Software Development :: Libraries :: Application Frameworks",
         "Topic :: Software Development :: Libraries :: Python Modules",
     ],
+    python_requires=">=3.5",
     install_requires=["scrapy>=1.6.0", "w3lib"],
 )

tests/test_stats.py

@@ -49,8 +49,8 @@ def test_stats(mocked_time):
     assert middleware.stats.get_value("crawlera_fetch/avg_latency") == avg_latency
     assert middleware.stats.get_value("crawlera_fetch/max_latency") == max_latency
     for status in set(status_list):
-        status_count = middleware.stats.get_value(f"crawlera_fetch/response_status_count/{status}")
-        assert status_count == status_list.count(status)
+        sc = middleware.stats.get_value("crawlera_fetch/response_status_count/{}".format(status))
+        assert sc == status_list.count(status)
     for method in set(method_list):
-        method_count = middleware.stats.get_value(f"crawlera_fetch/request_method_count/{method}")
-        assert method_count == method_list.count(method)
+        mc = middleware.stats.get_value("crawlera_fetch/request_method_count/{}".format(method))
+        assert mc == method_list.count(method)

tox.ini

@@ -1,5 +1,5 @@
 [tox]
-envlist = flake8,black,typing,py3.6,py3.7,py3.8
+envlist = flake8,black,typing,py3.5,py3.6,py3.7,py3.8
 
 
 [testenv]
@@ -23,6 +23,9 @@ deps = mypy==0.770
 basepython = python3.8
 commands = mypy --ignore-missing-imports --follow-imports=skip crawlera_fetch tests
 
+[testenv:py3.5]
+basepython = python3.5
+
 [testenv:py3.6]
 basepython = python3.6