Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The track_errors ini directive has been removed in PHP 8.0. #458

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

xrow
Copy link
Contributor

@xrow xrow commented Jul 23, 2024

The track_errors ini directive has been removed in PHP 8.0. This means that php_errormsg is no longer available.

https://www.php.net/manual/en/migration80.php

I see unneded log output and error, when you still have to set to ON:

2024-07-23T12:04:44.275489753Z [23-Jul-2024 14:04:44] NOTICE: PHP message: PHP Fatal error:  Directive 'track_errors' is no longer available in PHP in Unknown on line 0
2024-07-23T12:04:44.275542281Z <br />
2024-07-23T12:04:44.275547959Z <b>Fatal error</b>:  Directive 'track_errors' is no longer available in PHP in <b>Unknown</b> on line <b>0</b><br />

If this pull gets accepted will this fix https://catalog.redhat.com/software/containers/ubi9/php-82/657b0176999f2e3662c8159b in the future?

@hhorak
Copy link
Member

hhorak commented Jul 31, 2024

@remicollet can you, please, look at this?

Copy link
Contributor

@remicollet remicollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

github-actions bot commented Sep 27, 2024

Pull Request validation

Success

🟢 CI - All checks have passed
🟢 Review - Reviewed by a member
🟢 Approval - Changes were approved


Auto Merge

Failed

🔴 Pull Request has unsupported target branch master, expected branches are: ''

Success

🟢 Pull Request is not marked as draft and it's not blocked by dont-merge label
🟢 Pull Request meet requirements, title has correct form
🟢 Pull Request meet requirements, mergeable is true
🟢 Pull Request meet requirements, mergeable_state is clean

@xrow
Copy link
Contributor Author

xrow commented Sep 27, 2024

@hhorak Anythign i need todo?

@phracek
Copy link
Member

phracek commented Sep 30, 2024

As soon as tests passed, I will merge them. We already have approve

[test-all]

Copy link

github-actions bot commented Sep 30, 2024

Testing Farm results

namecomposearchstatusstarted (UTC)timelogs
Fedora - 8.1Fedora-latestx86_64✅ passed30.09.2024 07:36:3317min 42stest pipeline
RHEL9 - PyTest - OpenShift 4 - 8.1RHEL-9.4.0-Nightlyx86_64✅ passed30.09.2024 07:37:4917min 1stest pipeline
RHEL9 - OpenShift 4 - 8.1RHEL-9.4.0-Nightlyx86_64✅ passed30.09.2024 07:36:5117min 56stest pipeline
RHEL9 - PyTest - OpenShift 4 - 8.0RHEL-9.4.0-Nightlyx86_64✅ passed30.09.2024 07:37:2117min 17stest pipeline
Fedora - 8.2Fedora-latestx86_64✅ passed30.09.2024 07:36:3419min 4stest pipeline
RHEL8 - OpenShift 4 - 7.4RHEL-8.10.0-Nightlyx86_64✅ passed30.09.2024 07:36:4019min 55stest pipeline
RHEL8 - OpenShift 4 - 8.0RHEL-8.10.0-Nightlyx86_64✅ passed30.09.2024 07:36:4519min 43stest pipeline
RHEL8 - PyTest - OpenShift 4 - 8.2RHEL-8.10.0-Nightlyx86_64✅ passed30.09.2024 07:37:3319min 29stest pipeline
RHEL8 - PyTest - OpenShift 4 - 8.0RHEL-8.10.0-Nightlyx86_64✅ passed30.09.2024 07:37:0019min 49stest pipeline
RHEL8 - OpenShift 4 - 8.2RHEL-8.10.0-Nightlyx86_64✅ passed30.09.2024 07:36:5120min 24stest pipeline
RHEL9 - 8.0RHEL-9.4.0-Nightlyx86_64✅ passed30.09.2024 07:36:2822min 33stest pipeline
RHEL9 - OpenShift 4 - 8.0RHEL-9.4.0-Nightlyx86_64✅ passed30.09.2024 08:08:2318min 11stest pipeline
RHEL9 - OpenShift 4 - 8.2RHEL-9.4.0-Nightlyx86_64✅ passed30.09.2024 08:08:2218min 12stest pipeline
RHEL9 - 8.2RHEL-9.4.0-Nightlyx86_64✅ passed30.09.2024 07:36:3523min 15stest pipeline
RHEL9 - 8.1RHEL-9.4.0-Nightlyx86_64✅ passed30.09.2024 07:36:3723min 23stest pipeline
RHEL8 - 8.2RHEL-8.10.0-Nightlyx86_64✅ passed30.09.2024 07:36:3527min 11stest pipeline
RHEL8 - 8.0RHEL-8.10.0-Nightlyx86_64✅ passed30.09.2024 07:36:2628min 19stest pipeline
RHEL8 - 7.4RHEL-8.10.0-Nightlyx86_64✅ passed30.09.2024 07:36:2428min 43stest pipeline
RHEL9 - PyTest - OpenShift 4 - 8.2RHEL-9.4.0-Nightlyx86_64✅ passed30.09.2024 07:54:5824min 32stest pipeline

@phracek phracek merged commit 76fec7b into sclorg:master Sep 30, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants