Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightly requirement parsing for different cases. #88

Open
YooSunYoung opened this issue Nov 13, 2023 · 4 comments
Open

Nightly requirement parsing for different cases. #88

YooSunYoung opened this issue Nov 13, 2023 · 4 comments

Comments

@YooSunYoung
Copy link
Member

When I was trying to add more nightly dependencies of beamlime, I ran into these cases:

  • Package name is not same as repository name. (for ess-dmsc/ess-streaming-data-types)
  • Default branch is master not main. (for Textualize/rich)

Both of the dependencies I mentioned don't really have to be nightly dependencies,
since ess-streaming-data-types is not actively updated at the moment,
and Textualize/rich is relatively mature package, so breaking changes are not expected.

But I am reporting this issue since these cases might come again later,
for example, ess-steraming-data-types (from https://github.com/ess-dmsc/python-streaming-data-types) might be actively maintained later,
then we will want to add them into the nightly dependencies.

So if we run into these cases again, maybe we can update the copier answers format and make_base.py to support these cases.

@SimonHeybrock
Copy link
Member

It should work if you pass ess-dmsc/ess-streaming-data-types, I think I have tested that. The branch is indeed hard-coded to main currently.

@YooSunYoung
Copy link
Member Author

It should work if you pass ess-dmsc/ess-streaming-data-types, I think I have tested that. The branch is indeed hard-coded to main currently.

Oh I see, I thought it wouldn't work because the repository name is different from the package name.

@YooSunYoung
Copy link
Member Author

Hmm but I just tried, but it asks for user name and password of my github for some reason...?

@SimonHeybrock
Copy link
Member

Hmm, odd, given https://github.com/scipp/copier_template/blob/3e3c192b2d65522c6f5cb58d43e61d65d9940fd4/template/requirements/make_base.py#L45C23-L45C40 I would think it should clone via https, i.e., without requiring authentication?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants