Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put conda deployment into release env #220

Open
jl-wynen opened this issue Sep 26, 2024 · 2 comments
Open

Put conda deployment into release env #220

jl-wynen opened this issue Sep 26, 2024 · 2 comments

Comments

@jl-wynen
Copy link
Member

The PyPI deployment is in the 'release' environment. This means that it needs to be approved in order to run. But the conda deployment simply runs.

Should by also put the conda deployment into the 'release' environment?

This can not really be fixed in the copier template. But it affects all repos and I didn't know where else to put it.

@SimonHeybrock
Copy link
Member

Since conda allows replacing packages whereas PyPI does not I think it may be fine as it is?

@jl-wynen
Copy link
Member Author

It still increases the risk of having a broken or compromised package out there. We would have to react quickly and remove it once we notice that it has been deployed.
There is no extra cost to releasing if we put conda into the release env.

@nvaytet nvaytet changed the title Put conda deplyoment into release env Put conda deployment into release env Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants