Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More authors in copyright notice? #218

Open
jl-wynen opened this issue Sep 20, 2024 · 12 comments · May be fixed by #219
Open

More authors in copyright notice? #218

jl-wynen opened this issue Sep 20, 2024 · 12 comments · May be fixed by #219
Labels
question Further information is requested

Comments

@jl-wynen
Copy link
Member

Our copyright notice (and package metadata) lists 'Scipp contributors' as authors with a link to the Scipp GH org. The org only shows the core devs. This means that other contributors are not directly visible. This could be an issue esp. for ESS* packages.

Should we change the copyright to list the specific package / repo instead of the org? Or is there an other way to clearly include everyone?

@jl-wynen jl-wynen added the question Further information is requested label Sep 20, 2024
@nvaytet
Copy link
Member

nvaytet commented Sep 20, 2024

Maybe each project could have it different? In the copier template? For example we could have ESSsans contributors, that would point to https://github.com/scipp/esssans/graphs/contributors ?

@SimonHeybrock
Copy link
Member

SimonHeybrock commented Sep 25, 2024

Or link to a page in the docs such as https://scipp.github.io/esssans/developer/index.html, where contributors can be added?

But note that in any case, copyright holder is ESS, not any of their employees like us, as far as I understand?

@nvaytet
Copy link
Member

nvaytet commented Sep 25, 2024

I guess copyright holder is ESS for ESS employees but this being an open source project what do we do if we have external contributors?

@jl-wynen
Copy link
Member Author

They hold the copyright for their contributions.

As I understand it, if we use (with the correct package inserted)

# Copyright (c) 2024 $PACKAGE contributors

then this means that every contributor, or their employer, holds the copyright to their contributions.

I think that if we use the organisation instead of the package in the copyright notice, we don't include all contributors. But we should.

@nvaytet
Copy link
Member

nvaytet commented Sep 25, 2024

Doesn't this go back to an old discussion we had about whether we even need the copyright notice in every file?
We should keep the license identifier, but can we just remove the copyright (and also the annoying year that comes with it?)

@jl-wynen
Copy link
Member Author

That only solves part of the problem. We still have to name authors in the license file.

@nvaytet
Copy link
Member

nvaytet commented Sep 25, 2024

That only solves part of the problem. We still have to name authors in the license file.

True 😅

@SimonHeybrock
Copy link
Member

Not sure anyone who ever contributed a single line should hold copyright on the entire project?

@jl-wynen
Copy link
Member Author

They don't They have the copyright of that line. But we can't reasonable track this with comments. This is Git's job.

@MridulS
Copy link
Member

MridulS commented Sep 25, 2024

In theory it doesn't even matter I think? Depending on national law they (or their employer) just own the copyright for their contributions, doesn't matter what we put in the header, we don't require any CLA. Something like # Copyright (c) 2024 $PACKAGE contributors should be just fine. We don't really need to have the names in an author's list either, it's just a good to have from what I know.

@jl-wynen
Copy link
Member Author

Agree. My point is to move away from listing the organisation members as copyright holders.

@nvaytet
Copy link
Member

nvaytet commented Sep 25, 2024

Can we remove the copyright notice from the files and just have it in the license, so that we don't have to constantly update the years in the files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
Status: Triage
Development

Successfully merging a pull request may close this issue.

4 participants