Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

from skmatter.sample_selection import DirectionalConvexHull is failing #235

Open
DavideTisi opened this issue Jan 19, 2025 · 4 comments
Open

Comments

@DavideTisi
Copy link

I had a notebook in the atomistic-cookbook that does from skmatter.sample_selection import DirectionalConvexHull

And this command is failing with the error:

Traceback (most recent call last):
  File "<python-input-0>", line 1, in <module>
    from skmatter.sample_selection import DirectionalConvexHull
  File "/home/tisi/miniconda3/envs/prova-skmatter/lib/python3.13/site-packages/skmatter/sample_selection/__init__.py", line 6, in <module>
    from ._base import (
    ...<5 lines>...
    )
  File "/home/tisi/miniconda3/envs/prova-skmatter/lib/python3.13/site-packages/skmatter/sample_selection/_base.py", line 9, in <module>
    from scipy.interpolate.interpnd import _ndim_coords_from_arrays
ImportError: cannot import name '_ndim_coords_from_arrays' from 'scipy.interpolate.interpnd' (/home/tisi/miniconda3/envs/prova-skmatter/lib/python3.13/site-packages/scipy/interpolate/interpnd.py)

I also tested creating a new environment pip installing skmatter and running from skmatter.sample_selection import DirectionalConvexHull on a python terminal and I get the same error.

  • I tested with python 3.13 (and 3.11)
  • scipy 1.15.1 ( which is automatically downloaded by pip when installing skmatter)
  • numpy 2.2.2 (again automatically downloaded by pip when installing skmatter)
@Luthaf
Copy link
Collaborator

Luthaf commented Jan 20, 2025

The _ndim_coords_from_arrays function is private, so this is likely a change from one version of scipy to another.

@DavideTisi
Copy link
Author

yes, in the atomistic cookbook, I "fixed" the problem when I pinned a older version of scipy

@PicoCentauri
Copy link
Collaborator

Let me see if I am able to fix this :-).

@PicoCentauri
Copy link
Collaborator

It was just moved. See scipy/scipy#21754 for details. I will fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants