Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] allow different plotting styles for plot_ratio #547

Open
jonas-eschle opened this issue Nov 8, 2023 · 1 comment
Open

[FEATURE] allow different plotting styles for plot_ratio #547

jonas-eschle opened this issue Nov 8, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@jonas-eschle
Copy link
Contributor

jonas-eschle commented Nov 8, 2023

Describe the problem, if any, that your feature request is related to

plot_ratio currently uses the default histplot from mplhep, see

self_artists = histplot(self, ax=main_ax, label=rp_kwargs["num_label"])

Currently, there is no possibility to customize this plot, i.e. to change the plot style (errorbars, filled, etc), activate yerr etc.

Describe the feature you'd like

Being able to customize it would mean to be able to pass through arguments (and I think there is technically no reason not to allow this). I would suggest an argument histplotkwargs or something similar that is dict-like, passed in and expanded in histplot.

I can gladly make the PR if that's inline with the design.

Alternative

Of course, the refactoring as proposed here #192 would very well solve this problem too

@jonas-eschle jonas-eschle added the enhancement New feature or request label Nov 8, 2023
@AlbertoPdRF
Copy link

Hi,

Just checking: is there any chance of this issue getting addressed? Being able to style this kind of plot to match the style of others would be awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants