Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Option for steps in ratio panel in addition to dots #480

Open
JaLuka98 opened this issue Mar 5, 2023 · 0 comments
Open

[FEATURE] Option for steps in ratio panel in addition to dots #480

JaLuka98 opened this issue Mar 5, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@JaLuka98
Copy link

JaLuka98 commented Mar 5, 2023

Describe the problem, if any, that your feature request is related to

In the bottom panel of ratio plots, black dots are always drawn, leaving no flexibility for user choices, such as a "step ratio" with a piecewise continuous function and associated error bars per bin.
See

_ratio_points = ax.scatter(x_values, ratio, color="black")
for the relevant section in the code (plot_ratio_array).

Describe the feature you'd like

Possibility for a step line in the ratio panel in addition to the default scatter points.
Point of attack would be

_ratio_points = ax.scatter(x_values, ratio, color="black")
.
Proposing an additional argument to handle this. Can be passed as part of rp_kwargs.

Describe alternatives, if any, you've considered

No alternatives that respect the current structure of plot_ratio_arrays come to mind because the formatting of the ratio plot is "hardcoded" in that function.


Can you let me know if you find this reasonable? I could try to implement this myself and check how it works.

@JaLuka98 JaLuka98 added the enhancement New feature or request label Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant