From c5a7be905804195799715cf2ee425ae82c894f57 Mon Sep 17 00:00:00 2001 From: Jan Eglinger Date: Tue, 19 Jul 2022 10:09:02 +0200 Subject: [PATCH 1/2] Clean up imports and comments --- .../org/scijava/ui/swing/widget/SwingNumberWidgetTest.java | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/test/java/org/scijava/ui/swing/widget/SwingNumberWidgetTest.java b/src/test/java/org/scijava/ui/swing/widget/SwingNumberWidgetTest.java index 7750785..7bde962 100644 --- a/src/test/java/org/scijava/ui/swing/widget/SwingNumberWidgetTest.java +++ b/src/test/java/org/scijava/ui/swing/widget/SwingNumberWidgetTest.java @@ -33,7 +33,6 @@ import java.io.StringReader; import java.lang.reflect.Field; -import java.util.ArrayList; import java.util.Collections; import javax.swing.JSpinner; @@ -41,7 +40,6 @@ import org.junit.After; import org.junit.Before; -import org.junit.Ignore; import org.junit.Test; import org.scijava.Context; import org.scijava.module.Module; @@ -49,8 +47,6 @@ import org.scijava.module.ModuleItem; import org.scijava.module.ModuleService; import org.scijava.script.ScriptInfo; -import org.scijava.script.ScriptService; -import org.scijava.util.ListUtils; import org.scijava.widget.InputWidget; import org.scijava.widget.WidgetModel; import org.scijava.widget.WidgetService; @@ -81,9 +77,7 @@ public void test() throws NoSuchFieldException, SecurityException, IllegalArgume String script = createScript(); ScriptInfo info = new ScriptInfo(context, ".bsizes", new StringReader(script)); - //System.err.println(moduleService); Module module = moduleService.createModule(info); - //Module module = info.createModule(); Iterable> inputs = info.inputs(); SwingInputPanel inputPanel = new SwingInputPanel(); int i = 0; From 2d36f9d296d3a6feb8e8bdeeab24e9145af39bdc Mon Sep 17 00:00:00 2001 From: Jan Eglinger Date: Tue, 19 Jul 2022 10:11:23 +0200 Subject: [PATCH 2/2] SwingNumberWidgetTest: add BigInteger parameter Previous to https://github.com/scijava/scijava-ui-swing/commit/40bd474d8b9b169d521a621ddf9772a718ce6e26, this would throw a NullPointerException. Fixes https://github.com/scijava/scijava-ui-swing/issues/70. --- .../org/scijava/ui/swing/widget/SwingNumberWidgetTest.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/test/java/org/scijava/ui/swing/widget/SwingNumberWidgetTest.java b/src/test/java/org/scijava/ui/swing/widget/SwingNumberWidgetTest.java index 7bde962..399604e 100644 --- a/src/test/java/org/scijava/ui/swing/widget/SwingNumberWidgetTest.java +++ b/src/test/java/org/scijava/ui/swing/widget/SwingNumberWidgetTest.java @@ -109,7 +109,8 @@ private String[] getExpectedValues() { "1.000", "1.0000", "1.000", - "1.0000" + "1.0000", + "0" }; } @@ -135,6 +136,9 @@ private String createScript() { "#@ Double (value=1, min=0, max=10, stepSize=0.001, persist=false, style=\"slider,format:0.0000\") n\n" + "#@ Double (value=1, min=0, max=10, stepSize=0.001, persist=false, style=\"scroll bar\") o\n" + "#@ Double (value=1, min=0, max=10, stepSize=0.001, persist=false, style=\"scroll bar,format:0.0000\") p\n" + + "\n" + + "// BigInteger without min, max, stepSize\n" + + "#@ BigInteger (persist=false) q\n" + ""; return script; }