From 933967fd36428c7d2a11cd447527f45b37593ca6 Mon Sep 17 00:00:00 2001 From: Jonathan Leitschuh Date: Tue, 9 Aug 2022 03:28:48 +0000 Subject: [PATCH] vuln-fix: Temporary Directory Hijacking or Information Disclosure This fixes either Temporary Directory Hijacking, or Temporary Directory Local Information Disclosure. Weakness: CWE-379: Creation of Temporary File in Directory with Insecure Permissions Severity: High CVSSS: 7.3 Detection: CodeQL & OpenRewrite (https://public.moderne.io/recipes/org.openrewrite.java.security.UseFilesCreateTempDirectory) Reported-by: Jonathan Leitschuh Signed-off-by: Jonathan Leitschuh Bug-tracker: https://github.com/JLLeitschuh/security-research/issues/10 Co-authored-by: Moderne --- src/main/java/org/scijava/util/FileUtils.java | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/main/java/org/scijava/util/FileUtils.java b/src/main/java/org/scijava/util/FileUtils.java index 4de14f37f..5bc08fe7c 100644 --- a/src/main/java/org/scijava/util/FileUtils.java +++ b/src/main/java/org/scijava/util/FileUtils.java @@ -43,6 +43,7 @@ import java.net.URI; import java.net.URISyntaxException; import java.net.URL; +import java.nio.file.Files; import java.util.ArrayList; import java.util.Calendar; import java.util.Collection; @@ -472,14 +473,10 @@ public static File createTemporaryDirectory(final String prefix, final String suffix, final File directory) throws IOException { for (int counter = 0; counter < 10; counter++) { - final File file = File.createTempFile(prefix, suffix, directory); - - if (!file.delete()) { - throw new IOException("Could not delete file " + file); - } + final File file = Files.createTempDirectory(directory.toPath(), prefix + suffix).toFile(); // in case of a race condition, just try again - if (file.mkdir()) return file; + if (true) return file; } throw new IOException( "Could not create temporary directory (too many race conditions?)");