Merge pull request #2 from scaytrase/feature/refactoring

Refactoring.

* Standalone service
* Custom transports
* Profiler

Author: scaytrase

.properties

@@ -0,0 +1,37 @@
+language: php
+
+php:
+  - 5.4
+  - 5.5
+  - 5.6
+  - hhvm
+
+env:
+  - SYMFONY_VERSION='2.3.*' deps='no'
+  - SYMFONY_VERSION='2.5.*' deps='no'
+  - SYMFONY_VERSION='2.6.*' deps='no'
+  - SYMFONY_VERSION='2.7.*@dev' deps='no'
+
+matrix:
+    include:
+      - php: 5.5
+        env: SYMFONY_VERSION='~2.8@dev' deps='no'
+      - php: 5.5
+        env: SYMFONY_VERSION='~2.8|~3.0@dev' deps='no'
+      - php: 5.4
+        env: SYMFONY_VERSION='2.3.*' deps='low'
+
+    allow_failures:
+        - php: hhvm
+
+before_install:
+  - travis_retry composer self-update
+
+install:
+    - composer require --no-update symfony/symfony=${SYMFONY_VERSION}
+    - if [ "$deps" = "no" ]; then composer --prefer-source install; fi;
+    - if [ "$deps" = "low" ]; then composer --prefer-source --prefer-lowest --prefer-stable update; fi;
+
+script:
+  - mkdir -p build
+  - phpunit --colors -c phpunit.xml --coverage-text

.travis.yml

@@ -1,66 +1,68 @@
 
-# symfony-sms-interface
+# scaytrase/symfony-sms-delivery-bundle
 [![Latest Stable Version](https://poser.pugx.org/scaytrase/symfony-sms-interface/v/stable.svg)](https://packagist.org/packages/scaytrase/symfony-sms-interface) [![Total Downloads](https://poser.pugx.org/scaytrase/symfony-sms-interface/downloads.svg)](https://packagist.org/packages/scaytrase/symfony-sms-interface) [![Latest Unstable Version](https://poser.pugx.org/scaytrase/symfony-sms-interface/v/unstable.svg)](https://packagist.org/packages/scaytrase/symfony-sms-interface) [![License](https://poser.pugx.org/scaytrase/symfony-sms-interface/license.svg)](https://packagist.org/packages/scaytrase/symfony-sms-interface)
 
 [![Monthly Downloads](https://poser.pugx.org/scaytrase/symfony-sms-interface/d/monthly.png)](https://packagist.org/packages/scaytrase/symfony-sms-interface)
 [![Daily Downloads](https://poser.pugx.org/scaytrase/symfony-sms-interface/d/daily.png)](https://packagist.org/packages/scaytrase/symfony-sms-interface)
 
-This Symfony2 bundle provides basic interface for sending short messages as a service
+This Symfony2 bundle provides basic service for sending short messages. This bundle does not provide you any finished implementation for communicating the SMS gateway. To use it you have use some transport implementation or implemenent a transport on your own. See [usage section](#Usage) for known implementations
 
-## Current features
+## Features
 
-- Extensible inteface and basic service class
-- Ability to disable delivery via config for testing purposes
-- Ability to force redirect messages for testing purposes
+### Current features
 
+- [x] Service and configurable transports
+- [x] Ability to disable delivery via config for testing purposes
+- [x] Ability to force redirect messages for testing purposes
+- [x] Profiling via Sf2 Toolbar
+ 
+### Planned features
 
-## Installation
-
-Installation is available via Composer
+- [ ] Bulk sending
+- [ ] Spooling and delayed sending
 
-### composer.json
+## Installation
 
+This bunde could be installed via Composer
 
 ```
-require: "scaytrase/symfony-sms-interface": "~0.2.0"
+composer require scaytrase/symfony-sms-delivery-bundle:~1.0
 ```
 
 ### app/AppKernel.php
 
 update your kernel bundle requirements as follows:
 
-```
+```php 
 $bundles = array(
-    ....
-    new ScayTrase\Utils\SMSDeliveryBundle\SMSDeliveryBundle(),
-    ....
+    //....
+    new ScayTrase\SmsDeliveryBundle\SmsDeliveryBundle(),
+    //....
     );
 ```
 
 ## Configuration
 
-Basic interface supports two optional parameters:
+Below is the configuration example and their default values
 
-```
+```yaml
 sms_delivery:
-    disable_delivery: true # disables actual delivery making every send return successful result. use profiler to get message details
+    transport: sms_delivery.dummy_sender # @id of the transport service 
+    disable_delivery: false # disables actual delivery making every send return successful result. use profiler to get message details
     delivery_recipient: null # when not null - sends every message to the specified recipient, ignoring actual recipient of the message.
 ```
 
 ## Usage
 
-To use this interface you must create a message class implementing  ``ShortMessageInterface`` and extend abstract MessageDeliveryService with your own delivery api service. As soon as you a ready to go, you must specify sender class via ``sms_delivery.class`` parameter.
+To use this interface you must create a message class implementing  ``ShortMessageInterface`` and implement a transport that delivers your message to end point sms gateway. You can refer my [WebSMS](https://github.com/scaytrase/symfony-websms-bundle) gateway implementation as a reference.
+ 
  
- Refer [DummyMessageDeliveryService](src/ScayTrase/Utils/SMSDeliveryBundle/Service/DummySender/DummyMessageDeliveryService.php) as an example. It is also set as a default delivery service for quick start usage.
-
-
 ### Example
 
-```
+```php 
 public function sendSmsAction(){
   $message = new YourMessage('5552368','Help!')
-  $sender = $this->get('sms_delivery.sender');
-  $result = $sender->send($message);
+  $result = $this->get('sms_delivery.sender')->send($message);
   return new Response('Delivery '. $result ? 'successful' ; 'failed');
 }
-```
+```

README.md

@@ -1,8 +1,8 @@
 {
-    "name": "scaytrase/symfony-sms-interface",
-    "description": "Symfony2 Bundle with simple interface for sending sms",
-    "minimum-stability": "dev",
-    "license": "GPLv2",
+    "name": "scaytrase/symfony-sms-delivery-bundle",
+    "description": "Symfony2 Bundle with service for sending sms",
+    "minimum-stability": "stable",
+    "license": "GPL-2.0+",
     "authors": [
         {
             "name": "Pavel Batanov",
@@ -14,15 +14,12 @@
         "symfony/symfony": "~2.4"
     },
     "require-dev": {
-        "scaytrase/symfony-test-utils": "dev-master",
-        "phpunit/phpunit": "~4.3",
-        "behat/behat": "~3.0",
-        "behat/mink-extension": "dev-master",
-        "behat/symfony2-extension": "dev-master"
+        "phpunit/phpunit": "~4.6@stable",
+        "scaytrase/symfony-test-utils": "~1.0"
     },
     "autoload": {
         "psr-0": {
-            "ScayTrase\\Utils\\SMSDeliveryBundle": "src/"
+            "": "src/"
         }
     }
 }