Skip to content

Improve exception handling in scalac #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jvican opened this issue Sep 28, 2017 · 2 comments
Open

Improve exception handling in scalac #887

jvican opened this issue Sep 28, 2017 · 2 comments

Comments

@jvican
Copy link
Member

jvican commented Sep 28, 2017

As put by @retronym in scala/scala#6067:

I'm guessing that partest is culpable for the old favourite, println(throwable.getMessage). But I'm not 100% sure, we've got similarly horrifying exception handling in the compiler itself.
A quick fix to diagnose this would be to add a commit that changes Run.compileInternal to catch Throwable and print the results to system out. That should show up in the partest log.

I've run into this issue while fixing issues in the typechecker lately. I think it would be handy to improve this soon. What about adding the stack trace information to the error handling of both partest and compileInternal?

@jvican
Copy link
Member Author

jvican commented Sep 29, 2017

I'll be sending a PR for this after 2.12.4. Suggestions are welcome.

@jvican jvican self-assigned this Sep 29, 2017
@jvican jvican removed their assignment Oct 27, 2017
@SethTisue SethTisue transferred this issue from scala/bug Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant