Skip to content

2.13 macro annotation test doesn't work on Windows #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SethTisue opened this issue May 11, 2018 · 4 comments
Closed

2.13 macro annotation test doesn't work on Windows #505

SethTisue opened this issue May 11, 2018 · 4 comments
Assignees
@SethTisue
Milestone
2.13.0-M4

Comments

@SethTisue
Copy link
Member

seen at https://scala-ci.typesafe.com/job/scala-2.13.x-integrate-windows/559/

[error] - macroAnnot/test
[error]   - macroAnnot/scalaInstance failed: java.util.NoSuchElementException: None.get
@SethTisue SethTisue added this to the 2.13.0-M4 milestone May 11, 2018
@adriaanm
Copy link
Contributor

the fix should be trivial in quickInstnace in the build I have a hardwired path. Could you look into it please?

@adriaanm adriaanm assigned SethTisue and unassigned adriaanm May 11, 2018
@SethTisue
Copy link
Member Author

sure

SethTisue added a commit to SethTisue/scala that referenced this issue May 11, 2018
@SethTisue
minor fixups to macro annotation testing
59e14e7 
fix it to work on Windows (scala/scala-dev#505) or at least give
better diagnostics if it doesn't

also supply a missing .gitignore entry
@SethTisue SethTisue mentioned this issue May 11, 2018
Merged
@SethTisue
Copy link
Member Author

scala/scala#6619

@SethTisue
Copy link
Member Author

(but see #506, it looks to me like the tests aren't actually being run on Windows, unless I'm seeing phantoms, or rather not-seeing not-phantoms)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SethTisue SethTisue

Labels
None yet
Projects
None yet
Milestone
2.13.0-M4
Development

No branches or pull requests
2 participants
@adriaanm @SethTisue