Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the AlgoCG parameter of the configuration #404

Open
sblauth opened this issue Mar 11, 2024 · 1 comment
Open

Update the AlgoCG parameter of the configuration #404

sblauth opened this issue Mar 11, 2024 · 1 comment
Assignees
Labels
config Issues and PRs concerning cashocs configuration
Milestone

Comments

@sblauth
Copy link
Owner

sblauth commented Mar 11, 2024

At the moment, the parameters for the nonlinear CG methods are specified, e.g., as

cg_periodic_restart = True
cg_periodic_its = 5
cg_relative_restart = False
cg_restart_tol = 0.5

So boolean parameters are used to activate certain behaviors and double parameters are used for specifying tolerances / iterations. This should be refactored, so that only the keys cg_periodic_restart = 5 is used (and a value of 0 means that this is not active), analogously for cg_restart_tol.

@sblauth sblauth self-assigned this Mar 11, 2024
@sblauth
Copy link
Owner Author

sblauth commented Jul 8, 2024

As this change will break the API, it can only be made once a new major release will be done.

@sblauth sblauth changed the title [Development] Update the AlgoCG parameter of the configuration Update the AlgoCG parameter of the configuration Sep 6, 2024
@sblauth sblauth added the config Issues and PRs concerning cashocs configuration label Sep 6, 2024
@sblauth sblauth added this to the v3.0 milestone Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config Issues and PRs concerning cashocs configuration
Projects
None yet
Development

No branches or pull requests

1 participant