Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TriggerVersionField triggers RemovedInDjango60Warning: Passing positional arguments to save() is deprecated #256

Open
wutje opened this issue Mar 14, 2025 · 4 comments

Comments

@wutje
Copy link

wutje commented Mar 14, 2025

In _wrap_save from TriggerVersionField the arguments force_insert, force_update and using are passed to save() as positional arguments.
Causing the warning to trigger.

IMHO there are two options:

  1. Drop them and just pass them on via kwargs. This breaks for users passing them in as positional arguments. Does anyone actually do this?
  2. Use *args (and later drop them when Django Concurrency only supports Django 6 or later), in case anyone is passing in positional arguments.

Any opinions or perhaps another solution?

@saxix
Copy link
Owner

saxix commented Mar 28, 2025

I'm in favor of Option 1, it is backward incompatible but safer. I do not have time to work on this in the short term, but I'll gladly accept PR.

@wutje
Copy link
Author

wutje commented Mar 31, 2025

I created #257. Which solved the warnings for my codebase.

@saxix
Copy link
Owner

saxix commented Apr 1, 2025

Looks like there are some conflicts. Can you have a look at that?

@wutje
Copy link
Author

wutje commented Apr 3, 2025

I updated the PR, somehow I did not fork at HEAD but ~20 commit earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants