Skip to content

Commit a10c67e

Browse files
jasonsandlinjasonsandlin
authored
Switching to W4 and warnings as errors (microsoft#449)
* Switching to W4 and warnings as errors * Fixing mock
1 parent 86c69fd commit a10c67e

23 files changed

+54
-83
lines changed

‎Build/libHttpClient.141.UWP.C/libHttpClient.141.UWP.C.vcxproj

+3-2
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,8 @@
7373
<ItemDefinitionGroup>
7474
<ClCompile>
7575
<PrecompiledHeader>Use</PrecompiledHeader>
76-
<WarningLevel>Level3</WarningLevel>
76+
<WarningLevel>Level4</WarningLevel>
77+
<TreatWarningAsError>true</TreatWarningAsError>
7778
<SDLCheck>true</SDLCheck>
7879
<AdditionalOptions>/bigobj /Zm300 %(AdditionalOptions)</AdditionalOptions>
7980
<ProgramDataBaseFileName>$(OutDir)$(ProjectName).pdb</ProgramDataBaseFileName>
@@ -187,4 +188,4 @@
187188
<ItemGroup>
188189
</ItemGroup>
189190
<Import Project="$(VCTargetsPath)\Microsoft.Cpp.targets" />
190-
</Project>
191+
</Project>

‎Build/libHttpClient.141.Win32.C/libHttpClient.141.Win32.C.vcxproj

+1-1
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@
6868
<ItemDefinitionGroup>
6969
<ClCompile>
7070
<PrecompiledHeader>Use</PrecompiledHeader>
71-
<WarningLevel>Level3</WarningLevel>
71+
<WarningLevel>Level4</WarningLevel>
7272
<TreatWarningAsError>true</TreatWarningAsError>
7373
<SDLCheck>true</SDLCheck>
7474
<AdditionalOptions>/bigobj /Zm300 %(AdditionalOptions)</AdditionalOptions>

‎Build/libHttpClient.141.XDK.C/libHttpClient.141.XDK.C.vcxproj

+2-1
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,8 @@
5353
<AdditionalUsingDirectories>$(WindowsSDK_WindowsMetadata);$(AdditionalUsingDirectories)</AdditionalUsingDirectories>
5454
<AdditionalOptions>/bigobj /Zm250 %(AdditionalOptions)</AdditionalOptions>
5555
<ProgramDataBaseFileName>$(OutDir)$(ProjectName).pdb</ProgramDataBaseFileName>
56-
<WarningLevel Condition="'$(Configuration)|$(Platform)'=='Debug|Durango'">Level4</WarningLevel>
56+
<WarningLevel>Level4</WarningLevel>
57+
<TreatWarningAsError>true</TreatWarningAsError>
5758
<MinimalRebuild>false</MinimalRebuild>
5859
<CompileAsWinRT>true</CompileAsWinRT>
5960
<SupportJustMyCode>false</SupportJustMyCode>

‎Build/libHttpClient.142.UWP.C/libHttpClient.142.UWP.C.vcxproj

+2-1
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,8 @@
7373
<ItemDefinitionGroup>
7474
<ClCompile>
7575
<PrecompiledHeader>Use</PrecompiledHeader>
76-
<WarningLevel>Level3</WarningLevel>
76+
<WarningLevel>Level4</WarningLevel>
77+
<TreatWarningAsError>true</TreatWarningAsError>
7778
<SDLCheck>true</SDLCheck>
7879
<AdditionalOptions>/bigobj /Zm300 %(AdditionalOptions)</AdditionalOptions>
7980
<ProgramDataBaseFileName>$(OutDir)$(ProjectName).pdb</ProgramDataBaseFileName>

‎Build/libHttpClient.142.Win32.C/libHttpClient.142.Win32.C.vcxproj

+1-1
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@
6868
<ItemDefinitionGroup>
6969
<ClCompile>
7070
<PrecompiledHeader>Use</PrecompiledHeader>
71-
<WarningLevel>Level3</WarningLevel>
71+
<WarningLevel>Level4</WarningLevel>
7272
<TreatWarningAsError>true</TreatWarningAsError>
7373
<SDLCheck>true</SDLCheck>
7474
<AdditionalOptions>/bigobj /Zm300 %(AdditionalOptions)</AdditionalOptions>

‎Build/libHttpClient.142.XDK.C/libHttpClient.142.XDK.C.vcxproj

+2-1
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,8 @@
5353
<AdditionalUsingDirectories>$(WindowsSDK_WindowsMetadata);$(AdditionalUsingDirectories)</AdditionalUsingDirectories>
5454
<AdditionalOptions>/bigobj /Zm250 %(AdditionalOptions)</AdditionalOptions>
5555
<ProgramDataBaseFileName>$(OutDir)$(ProjectName).pdb</ProgramDataBaseFileName>
56-
<WarningLevel Condition="'$(Configuration)|$(Platform)'=='Debug|Durango'">Level4</WarningLevel>
56+
<WarningLevel>Level4</WarningLevel>
57+
<TreatWarningAsError>true</TreatWarningAsError>
5758
<MinimalRebuild>false</MinimalRebuild>
5859
<CompileAsWinRT>true</CompileAsWinRT>
5960
<SupportJustMyCode>false</SupportJustMyCode>

‎Source/Common/Win/utils_win.cpp

+3
Original file line numberDiff line numberDiff line change
@@ -180,6 +180,9 @@ proxy_type get_ie_proxy_info(_In_ proxy_protocol protocol, _Inout_ xbox::httpcli
180180
{
181181
proxyType = proxy_type::no_proxy;
182182
}
183+
#else
184+
UNREFERENCED_PARAMETER(protocol);
185+
UNREFERENCED_PARAMETER(proxyUri);
183186
#endif
184187

185188
return proxyType;

‎Source/Global/global.cpp

+1
Original file line numberDiff line numberDiff line change
@@ -149,6 +149,7 @@ HRESULT http_singleton::set_global_proxy(_In_ const char* proxyUri)
149149
#if HC_PLATFORM == HC_PLATFORM_WIN32
150150
return Internal_SetGlobalProxy(m_performEnv.get(), proxyUri);
151151
#else
152+
UNREFERENCED_PARAMETER(proxyUri);
152153
return E_NOTIMPL;
153154
#endif
154155
}

‎Source/HTTP/WinHttp/winhttp_http_task.cpp

+4-40
Original file line numberDiff line numberDiff line change
@@ -579,40 +579,6 @@ void winhttp_http_task::callback_status_read_complete(
579579
}
580580
}
581581

582-
583-
static std::string HttpCallbackStatusCodeToString(DWORD statusCode)
584-
{
585-
switch (statusCode)
586-
{
587-
case WINHTTP_CALLBACK_STATUS_RESOLVING_NAME: return "WINHTTP_CALLBACK_STATUS_RESOLVING_NAME";
588-
case WINHTTP_CALLBACK_STATUS_NAME_RESOLVED: return "WINHTTP_CALLBACK_STATUS_NAME_RESOLVED";
589-
case WINHTTP_CALLBACK_STATUS_CONNECTING_TO_SERVER: return "WINHTTP_CALLBACK_STATUS_CONNECTING_TO_SERVER";
590-
case WINHTTP_CALLBACK_STATUS_CONNECTED_TO_SERVER: return "WINHTTP_CALLBACK_STATUS_CONNECTED_TO_SERVER";
591-
case WINHTTP_CALLBACK_STATUS_SENDING_REQUEST: return "WINHTTP_CALLBACK_STATUS_SENDING_REQUEST";
592-
case WINHTTP_CALLBACK_STATUS_REQUEST_SENT: return "WINHTTP_CALLBACK_STATUS_REQUEST_SENT";
593-
case WINHTTP_CALLBACK_STATUS_RECEIVING_RESPONSE: return "WINHTTP_CALLBACK_STATUS_RECEIVING_RESPONSE";
594-
case WINHTTP_CALLBACK_STATUS_RESPONSE_RECEIVED: return "WINHTTP_CALLBACK_STATUS_RESPONSE_RECEIVED";
595-
case WINHTTP_CALLBACK_STATUS_CLOSING_CONNECTION: return "WINHTTP_CALLBACK_STATUS_CLOSING_CONNECTION";
596-
case WINHTTP_CALLBACK_STATUS_CONNECTION_CLOSED: return "WINHTTP_CALLBACK_STATUS_CONNECTION_CLOSED";
597-
case WINHTTP_CALLBACK_STATUS_HANDLE_CREATED: return "WINHTTP_CALLBACK_STATUS_HANDLE_CREATED";
598-
case WINHTTP_CALLBACK_STATUS_HANDLE_CLOSING: return "WINHTTP_CALLBACK_STATUS_HANDLE_CLOSING";
599-
case WINHTTP_CALLBACK_STATUS_DETECTING_PROXY: return "WINHTTP_CALLBACK_STATUS_DETECTING_PROXY";
600-
case WINHTTP_CALLBACK_STATUS_REDIRECT: return "WINHTTP_CALLBACK_STATUS_REDIRECT";
601-
case WINHTTP_CALLBACK_STATUS_INTERMEDIATE_RESPONSE: return "WINHTTP_CALLBACK_STATUS_INTERMEDIATE_RESPONSE";
602-
case WINHTTP_CALLBACK_STATUS_SECURE_FAILURE: return "WINHTTP_CALLBACK_STATUS_SECURE_FAILURE";
603-
case WINHTTP_CALLBACK_STATUS_HEADERS_AVAILABLE: return "WINHTTP_CALLBACK_STATUS_HEADERS_AVAILABLE";
604-
case WINHTTP_CALLBACK_STATUS_DATA_AVAILABLE: return "WINHTTP_CALLBACK_STATUS_DATA_AVAILABLE";
605-
case WINHTTP_CALLBACK_STATUS_READ_COMPLETE: return "WINHTTP_CALLBACK_STATUS_READ_COMPLETE";
606-
case WINHTTP_CALLBACK_STATUS_WRITE_COMPLETE: return "WINHTTP_CALLBACK_STATUS_WRITE_COMPLETE";
607-
case WINHTTP_CALLBACK_STATUS_REQUEST_ERROR: return "WINHTTP_CALLBACK_STATUS_REQUEST_ERROR";
608-
case WINHTTP_CALLBACK_STATUS_SENDREQUEST_COMPLETE: return "WINHTTP_CALLBACK_STATUS_SENDREQUEST_COMPLETE";
609-
case WINHTTP_CALLBACK_STATUS_GETPROXYFORURL_COMPLETE: return "WINHTTP_CALLBACK_STATUS_GETPROXYFORURL_COMPLETE";
610-
case WINHTTP_CALLBACK_STATUS_CLOSE_COMPLETE: return "WINHTTP_CALLBACK_STATUS_CLOSE_COMPLETE";
611-
case WINHTTP_CALLBACK_STATUS_SHUTDOWN_COMPLETE: return "WINHTTP_CALLBACK_STATUS_SHUTDOWN_COMPLETE";
612-
default: return "Unknown";
613-
}
614-
}
615-
616582
void CALLBACK winhttp_http_task::completion_callback(
617583
HINTERNET hRequestHandle,
618584
DWORD_PTR context,
@@ -667,7 +633,7 @@ void CALLBACK winhttp_http_task::completion_callback(
667633
if (pRequestContext->m_isWebSocket)
668634
{
669635
#if HC_WINHTTP_WEBSOCKETS
670-
callback_websocket_status_headers_available(hRequestHandle, pRequestContext, statusInfo);
636+
callback_websocket_status_headers_available(hRequestHandle, pRequestContext);
671637
#endif
672638
}
673639
else
@@ -688,7 +654,7 @@ void CALLBACK winhttp_http_task::completion_callback(
688654
if (pRequestContext->m_isWebSocket)
689655
{
690656
#if HC_WINHTTP_WEBSOCKETS
691-
callback_websocket_status_read_complete(hRequestHandle, pRequestContext, statusInfo);
657+
callback_websocket_status_read_complete(pRequestContext, statusInfo);
692658
#endif
693659
}
694660
else
@@ -764,7 +730,7 @@ void winhttp_http_task::set_autodiscover_proxy(
764730
&info);
765731
if (result)
766732
{
767-
auto result = WinHttpSetOption(
733+
result = WinHttpSetOption(
768734
m_hRequest,
769735
WINHTTP_OPTION_PROXY,
770736
&info,
@@ -1237,7 +1203,6 @@ char* winhttp_http_task::winhttp_web_socket_buffer_type_to_string(
12371203
}
12381204

12391205
void winhttp_http_task::callback_websocket_status_read_complete(
1240-
_In_ HINTERNET hRequestHandle,
12411206
_In_ winhttp_http_task* pRequestContext,
12421207
_In_ void* statusInfo)
12431208
{
@@ -1367,8 +1332,7 @@ HRESULT winhttp_http_task::websocket_read_message()
13671332

13681333
void winhttp_http_task::callback_websocket_status_headers_available(
13691334
_In_ HINTERNET hRequestHandle,
1370-
_In_ winhttp_http_task* pRequestContext,
1371-
_In_ void* statusInfo)
1335+
_In_ winhttp_http_task* pRequestContext)
13721336
{
13731337
HC_TRACE_INFORMATION(HTTPCLIENT, "HCHttpCallPerform [ID %llu] [TID %ul] Websocket WINHTTP_CALLBACK_STATUS_HEADERS_AVAILABLE", HCHttpCallGetId(pRequestContext->m_call), GetCurrentThreadId());
13741338

‎Source/HTTP/WinHttp/winhttp_http_task.h

+1-3
Original file line numberDiff line numberDiff line change
@@ -231,11 +231,9 @@ class winhttp_http_task : public xbox::httpclient::hc_task
231231

232232
static void callback_websocket_status_headers_available(
233233
_In_ HINTERNET hRequestHandle,
234-
_In_ winhttp_http_task* pRequestContext,
235-
_In_ void* statusInfo);
234+
_In_ winhttp_http_task* pRequestContext);
236235

237236
static void callback_websocket_status_read_complete(
238-
_In_ HINTERNET hRequestHandle,
239237
_In_ winhttp_http_task* pRequestContext,
240238
_In_ void* statusInfo);
241239

‎Source/WebSocket/Websocketpp/websocketpp_websocket.cpp

+7
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,8 @@
2727
#pragma clang diagnostic ignored "-Wshorten-64-to-32"
2828
#endif
2929

30+
#pragma warning(disable: 4244)
31+
3032
#include <websocketpp/config/asio_client.hpp>
3133
#include <websocketpp/config/asio_no_tls_client.hpp>
3234
#include <websocketpp/client.hpp>
@@ -848,6 +850,8 @@ HRESULT CALLBACK Internal_HCWebSocketConnectAsync(
848850
_In_ HCPerformEnv env
849851
)
850852
{
853+
UNREFERENCED_PARAMETER(context);
854+
UNREFERENCED_PARAMETER(env);
851855
auto wsppSocket{ std::dynamic_pointer_cast<wspp_websocket_impl>(websocket->impl) };
852856

853857
if (!wsppSocket)
@@ -866,6 +870,7 @@ HRESULT CALLBACK Internal_HCWebSocketSendMessageAsync(
866870
_In_opt_ void* context
867871
)
868872
{
873+
UNREFERENCED_PARAMETER(context);
869874
std::shared_ptr<wspp_websocket_impl> wsppSocket = std::dynamic_pointer_cast<wspp_websocket_impl>(websocket->impl);
870875
if (wsppSocket == nullptr)
871876
{
@@ -882,6 +887,7 @@ HRESULT CALLBACK Internal_HCWebSocketSendBinaryMessageAsync(
882887
_In_opt_ void* context
883888
)
884889
{
890+
UNREFERENCED_PARAMETER(context);
885891
std::shared_ptr<wspp_websocket_impl> wsppSocket = std::dynamic_pointer_cast<wspp_websocket_impl>(websocket->impl);
886892
if (wsppSocket == nullptr)
887893
{
@@ -896,6 +902,7 @@ HRESULT CALLBACK Internal_HCWebSocketDisconnect(
896902
_In_opt_ void* context
897903
)
898904
{
905+
UNREFERENCED_PARAMETER(context);
899906
if (websocket == nullptr)
900907
{
901908
return E_INVALIDARG;

‎Source/WebSocket/hcwebsocket.cpp

-3
Original file line numberDiff line numberDiff line change
@@ -356,7 +356,6 @@ void HC_WEBSOCKET::MessageFunc(
356356
)
357357
{
358358
UNREFERENCED_PARAMETER(context);
359-
360359
std::lock_guard<std::recursive_mutex> lock{ websocket->m_mutex };
361360
if (websocket->m_clientRefCount > 0)
362361
{
@@ -382,7 +381,6 @@ void HC_WEBSOCKET::BinaryMessageFunc(
382381
)
383382
{
384383
UNREFERENCED_PARAMETER(context);
385-
386384
std::lock_guard<std::recursive_mutex> lock{ websocket->m_mutex };
387385
if (websocket->m_clientRefCount > 0)
388386
{
@@ -407,7 +405,6 @@ void HC_WEBSOCKET::CloseFunc(
407405
)
408406
{
409407
UNREFERENCED_PARAMETER(context);
410-
411408
{
412409
std::lock_guard<std::recursive_mutex> lock{ websocket->m_mutex };
413410

‎Tests/UnitTests/Tests/MockTests.cpp

+12-20
Original file line numberDiff line numberDiff line change
@@ -18,23 +18,15 @@ DEFINE_TEST_CLASS(MockTests)
1818
public:
1919
DEFINE_TEST_CLASS_PROPS(MockTests);
2020

21-
HCCallHandle CreateMockCall(CHAR* strResponse, bool makeSpecificUrl, bool makeSpecificBody)
21+
HCMockCallHandle CreateMockCall(CHAR* strResponse, bool makeSpecificUrl, bool makeSpecificBody)
2222
{
23-
HCCallHandle mockCall;
24-
VERIFY_ARE_EQUAL(S_OK, HCHttpCallCreate(&mockCall));
25-
if (makeSpecificUrl)
26-
{
27-
VERIFY_ARE_EQUAL(S_OK, HCHttpCallRequestSetUrl(mockCall, "1", "2"));
28-
}
29-
if (makeSpecificBody)
30-
{
31-
VERIFY_ARE_EQUAL(S_OK, HCHttpCallRequestSetRequestBodyString(mockCall, "requestBody"));
32-
}
33-
VERIFY_ARE_EQUAL(S_OK, HCHttpCallResponseSetNetworkErrorCode(mockCall, E_OUTOFMEMORY, 300));
34-
VERIFY_ARE_EQUAL(S_OK, HCHttpCallResponseSetStatusCode(mockCall, 400));
23+
HCMockCallHandle mockCall;
24+
VERIFY_ARE_EQUAL(S_OK, HCMockCallCreate(&mockCall));
25+
VERIFY_ARE_EQUAL(S_OK, HCMockResponseSetNetworkErrorCode(mockCall, E_OUTOFMEMORY, 300));
26+
VERIFY_ARE_EQUAL(S_OK, HCMockResponseSetStatusCode(mockCall, 400));
3527
std::string s1 = strResponse;
36-
VERIFY_ARE_EQUAL(S_OK, HCHttpCallResponseSetResponseBodyBytes(mockCall, (uint8_t*)&s1[0], s1.length()));
37-
VERIFY_ARE_EQUAL(S_OK, HCHttpCallResponseSetHeader(mockCall, "mockHeader", "mockValue"));
28+
VERIFY_ARE_EQUAL(S_OK, HCMockResponseSetResponseBodyBytes(mockCall, (uint8_t*)&s1[0], (uint32_t)s1.length()));
29+
VERIFY_ARE_EQUAL(S_OK, HCMockResponseSetHeader(mockCall, "mockHeader", "mockValue"));
3830
return mockCall;
3931
}
4032

@@ -47,7 +39,7 @@ DEFINE_TEST_CLASS(MockTests)
4739
VERIFY_ARE_EQUAL(S_OK, HCHttpCallCreate(&call));
4840
VERIFY_ARE_EQUAL(S_OK, HCHttpCallRequestSetRetryAllowed(call, false));
4941

50-
HCCallHandle mockCall = CreateMockCall("Mock1", false, false);
42+
HCMockCallHandle mockCall = CreateMockCall("Mock1", false, false);
5143
VERIFY_ARE_EQUAL(S_OK, HCMockAddMock(mockCall, "", "", nullptr, 0));
5244

5345
XTaskQueueHandle queue;
@@ -97,7 +89,7 @@ DEFINE_TEST_CLASS(MockTests)
9789

9890
VERIFY_ARE_EQUAL(S_OK, HCInitialize(nullptr));
9991

100-
HCCallHandle mockCall = CreateMockCall("Mock1", true, false);
92+
HCMockCallHandle mockCall = CreateMockCall("Mock1", true, false);
10193
VERIFY_ARE_EQUAL(S_OK, HCMockAddMock(mockCall, nullptr, nullptr, nullptr, 0));
10294

10395
HCCallHandle call = nullptr;
@@ -193,7 +185,7 @@ DEFINE_TEST_CLASS(MockTests)
193185

194186
VERIFY_ARE_EQUAL(S_OK, HCInitialize(nullptr));
195187

196-
HCCallHandle mockCall = CreateMockCall("Mock1", true, true);
188+
HCMockCallHandle mockCall = CreateMockCall("Mock1", true, true);
197189
VERIFY_ARE_EQUAL(S_OK, HCMockAddMock(mockCall, nullptr, nullptr, nullptr, 0));
198190

199191
HCCallHandle call = nullptr;
@@ -364,8 +356,8 @@ DEFINE_TEST_CLASS(MockTests)
364356

365357
VERIFY_ARE_EQUAL(S_OK, HCInitialize(nullptr));
366358

367-
HCCallHandle mockCall1 = CreateMockCall("Mock1", true, true);
368-
HCCallHandle mockCall2 = CreateMockCall("Mock2", true, true);
359+
HCMockCallHandle mockCall1 = CreateMockCall("Mock1", true, true);
360+
HCMockCallHandle mockCall2 = CreateMockCall("Mock2", true, true);
369361
VERIFY_ARE_EQUAL(S_OK, HCMockAddMock(mockCall1, nullptr, nullptr, nullptr, 0));
370362
VERIFY_ARE_EQUAL(S_OK, HCMockAddMock(mockCall2, nullptr, nullptr, nullptr, 0));
371363

‎Utilities/CMake/scripts/RunCMake.cmd

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ if NOT EXIST %CMAKE_EXE% set CMAKE_EXE="C:\Program Files (x86)\Microsoft Visual
1414
if NOT EXIST %CMAKE_EXE% set CMAKE_EXE="C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin\cmake.exe"
1515

1616
copy ..\CMakeLists.txt .
17-
%CMAKE_EXE% -G "Visual Studio 16 2019" %* CMakeLists.txt %CMAKE_FOLDER%\build
17+
%CMAKE_EXE% -G "Visual Studio 15 2017" %* CMakeLists.txt %CMAKE_FOLDER%\build
1818
if %ERRORLEVEL% NEQ 0 goto ignore
1919
call :subCopy
2020
goto done

‎Utilities/CMake/template-libHttpClient.140.UWP.C.vcxproj

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
<MinimumVisualStudioVersion>14.0</MinimumVisualStudioVersion>
3939
<AppContainerApplication>true</AppContainerApplication>
4040
<GenerateManifest>false</GenerateManifest>
41-
<WindowsTargetPlatformVersion>10.0.17763.0</WindowsTargetPlatformVersion>
41+
<WindowsTargetPlatformVersion>10.0.10586.0</WindowsTargetPlatformVersion>
4242
<WindowsTargetPlatformMinVersion>10.0.10240.0</WindowsTargetPlatformMinVersion>
4343
<PreferredToolArchitecture>x64</PreferredToolArchitecture>
4444
<HCLibPlatformType>UWP</HCLibPlatformType>

‎Utilities/CMake/template-libHttpClient.140.Win32.C.vcxproj

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
<DefaultLanguage>en-US</DefaultLanguage>
3636
<MinimumVisualStudioVersion>14.0</MinimumVisualStudioVersion>
3737
<PreferredToolArchitecture>x64</PreferredToolArchitecture>
38-
<WindowsTargetPlatformVersion>10.0.17763.0</WindowsTargetPlatformVersion>
38+
<WindowsTargetPlatformVersion>8.1</WindowsTargetPlatformVersion>
3939
<HCLibPlatformType>Win32</HCLibPlatformType>
4040
<HCLibImpl>true</HCLibImpl>
4141
</PropertyGroup>

‎Utilities/CMake/template-libHttpClient.141.UWP.C.vcxproj

+2-1
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,8 @@
7373
<ItemDefinitionGroup>
7474
<ClCompile>
7575
<PrecompiledHeader>Use</PrecompiledHeader>
76-
<WarningLevel>Level3</WarningLevel>
76+
<WarningLevel>Level4</WarningLevel>
77+
<TreatWarningAsError>true</TreatWarningAsError>
7778
<SDLCheck>true</SDLCheck>
7879
<AdditionalOptions>/bigobj /Zm300 %(AdditionalOptions)</AdditionalOptions>
7980
<ProgramDataBaseFileName>$(OutDir)$(ProjectName).pdb</ProgramDataBaseFileName>

‎Utilities/CMake/template-libHttpClient.141.Win32.C.vcxproj

+1-1
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@
6868
<ItemDefinitionGroup>
6969
<ClCompile>
7070
<PrecompiledHeader>Use</PrecompiledHeader>
71-
<WarningLevel>Level3</WarningLevel>
71+
<WarningLevel>Level4</WarningLevel>
7272
<TreatWarningAsError>true</TreatWarningAsError>
7373
<SDLCheck>true</SDLCheck>
7474
<AdditionalOptions>/bigobj /Zm300 %(AdditionalOptions)</AdditionalOptions>

‎Utilities/CMake/template-libHttpClient.141.XDK.C.vcxproj

+2-1
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,8 @@
5353
<AdditionalUsingDirectories>$(WindowsSDK_WindowsMetadata);$(AdditionalUsingDirectories)</AdditionalUsingDirectories>
5454
<AdditionalOptions>/bigobj /Zm250 %(AdditionalOptions)</AdditionalOptions>
5555
<ProgramDataBaseFileName>$(OutDir)$(ProjectName).pdb</ProgramDataBaseFileName>
56-
<WarningLevel Condition="'$(Configuration)|$(Platform)'=='Debug|Durango'">Level4</WarningLevel>
56+
<WarningLevel>Level4</WarningLevel>
57+
<TreatWarningAsError>true</TreatWarningAsError>
5758
<MinimalRebuild>false</MinimalRebuild>
5859
<CompileAsWinRT>true</CompileAsWinRT>
5960
<SupportJustMyCode>false</SupportJustMyCode>

‎Utilities/CMake/template-libHttpClient.142.UWP.C.vcxproj

+2-1
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,8 @@
7373
<ItemDefinitionGroup>
7474
<ClCompile>
7575
<PrecompiledHeader>Use</PrecompiledHeader>
76-
<WarningLevel>Level3</WarningLevel>
76+
<WarningLevel>Level4</WarningLevel>
77+
<TreatWarningAsError>true</TreatWarningAsError>
7778
<SDLCheck>true</SDLCheck>
7879
<AdditionalOptions>/bigobj /Zm300 %(AdditionalOptions)</AdditionalOptions>
7980
<ProgramDataBaseFileName>$(OutDir)$(ProjectName).pdb</ProgramDataBaseFileName>

‎Utilities/CMake/template-libHttpClient.142.Win32.C.vcxproj

+1-1
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@
6868
<ItemDefinitionGroup>
6969
<ClCompile>
7070
<PrecompiledHeader>Use</PrecompiledHeader>
71-
<WarningLevel>Level3</WarningLevel>
71+
<WarningLevel>Level4</WarningLevel>
7272
<TreatWarningAsError>true</TreatWarningAsError>
7373
<SDLCheck>true</SDLCheck>
7474
<AdditionalOptions>/bigobj /Zm300 %(AdditionalOptions)</AdditionalOptions>

0 commit comments

Comments
 (0)