refactor(ci): Use actions/upload-artifact to upload alpine packages

Author: vitoyucepi

.github/workflows/ci.yml

@@ -456,40 +456,39 @@ jobs:
           chown -R opam "${GITHUB_OUTPUT}"
           sudo -u opam -E ./.github/scripts/build-apk.sh ${{ needs.build_details.outputs.branch }} ${{ matrix.os }} ${{ matrix.platform }} ${{ matrix.alpine-arch }} "${{ needs.build_details.outputs.is_rolling_release }}" "${{ needs.build_details.outputs.is_release }}" "${{ needs.build_details.outputs.minimal_exclude_deps }}"
       - name: Upload alpine packages artifacts
-        if: needs.build_details.outputs.is_fork != 'true' && matrix.os == 'alpine'
-        uses: savonet/aws-s3-docker-action@master
+        if: contains(matrix.os, 'alpine')
+        uses: actions/upload-artifact@v4
         env:
-          AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
-          AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
-          SOURCE: ${{ github.workspace }}/${{ github.run_number }}/${{ matrix.os }}_${{ matrix.platform }}/alpine
-          TARGET: ${{ needs.build_details.outputs.s3-artifact-basepath }}
+          name: ${{ steps.build_apk.outputs.basename }}
+          path: ${{ github.workspace }}/${{ github.run_number }}/${{ matrix.os }}_${{ matrix.platform }}/alpine
+          if-no-files-found: error
       - name: Cleanup
         if: ${{ always() }}
         run: |
           rm -rf /tmp/${{ github.run_number }}/${{ matrix.os }}_${{ matrix.platform }}
 
-  fetch_s3_artifacts:
-    runs-on: ubuntu-latest
-    needs: [build_details, build_posix]
-    steps:
-      - name: Prepare directory
-        run: |
-          rm -rf ${{ github.workspace }}/${{ github.run_number }}/s3-artifacts
-          mkdir -p ${{ github.workspace }}/${{ github.run_number }}/s3-artifacts
-      - name: Fetch S3 artifacts
-        if: needs.build_details.outputs.is_fork != 'true'
-        uses: savonet/aws-s3-docker-action@master
-        env:
-          AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
-          AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
-          SOURCE: ${{ needs.build_details.outputs.s3-artifact-basepath }}
-          TARGET: ${{ github.workspace }}/${{ github.run_number }}/s3-artifacts
-      - name: Upload S3 artifacts
-        uses: actions/upload-artifact@v4
-        if: needs.build_details.outputs.is_fork != 'true'
-        with:
-          name: alpine-packages
-          path: ${{ github.workspace }}/${{ github.run_number }}/s3-artifacts
+  #  fetch_s3_artifacts:
+  #    runs-on: ubuntu-latest
+  #    needs: [build_details, build_posix]
+  #    steps:
+  #      - name: Prepare directory
+  #        run: |
+  #          rm -rf ${{ github.workspace }}/${{ github.run_number }}/s3-artifacts
+  #          mkdir -p ${{ github.workspace }}/${{ github.run_number }}/s3-artifacts
+  #      - name: Fetch S3 artifacts
+  #        if: needs.build_details.outputs.is_fork != 'true'
+  #        uses: savonet/aws-s3-docker-action@master
+  #        env:
+  #          AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
+  #          AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
+  #          SOURCE: ${{ needs.build_details.outputs.s3-artifact-basepath }}
+  #          TARGET: ${{ github.workspace }}/${{ github.run_number }}/s3-artifacts
+  #      - name: Upload S3 artifacts
+  #        uses: actions/upload-artifact@v4
+  #        if: needs.build_details.outputs.is_fork != 'true'
+  #        with:
+  #          name: alpine-packages
+  #          path: ${{ github.workspace }}/${{ github.run_number }}/s3-artifacts
 
   build_win32:
     runs-on: depot-ubuntu-22.04-4
@@ -551,7 +550,6 @@ jobs:
         run_tests,
         build_posix,
         build_win32,
-        fetch_s3_artifacts,
       ]
     if: needs.build_details.outputs.is_release
     steps:
@@ -615,7 +613,7 @@ jobs:
 
   build_docker:
     runs-on: ${{ matrix.runs-on }}
-    needs: [build_details, build_posix, fetch_s3_artifacts]
+    needs: [build_details, build_posix]
     strategy:
       fail-fast: false
       matrix:
@@ -666,7 +664,7 @@ jobs:
 
   build_docker_alpine:
     runs-on: ${{ matrix.runs-on }}
-    needs: [build_details, build_posix, fetch_s3_artifacts]
+    needs: [build_details, build_posix]
     strategy:
       fail-fast: false
       matrix:
@@ -712,7 +710,7 @@ jobs:
 
   build_docker_minimal:
     runs-on: ${{ matrix.runs-on }}
-    needs: [build_details, build_posix, fetch_s3_artifacts]
+    needs: [build_details, build_posix]
     strategy:
       fail-fast: false
       matrix:
@@ -763,7 +761,7 @@ jobs:
 
   build_docker_alpine_minimal:
     runs-on: ${{ matrix.runs-on }}
-    needs: [build_details, build_posix, fetch_s3_artifacts]
+    needs: [build_details, build_posix]
     strategy:
       fail-fast: false
       matrix: