Skip to content

Commit 5e03d1a

Browse files
authored
fix: Multiple fixes (#33)
* fix: Add timestamp * fix: Add missing var name for CARVEL_PACKAGE_SA * fix: Add missing metadata
1 parent 5dd8e76 commit 5e03d1a

File tree

3 files changed

+9
-6
lines changed

3 files changed

+9
-6
lines changed

Diff for: content/tutorials/carvel/packages/author/easy/kctrl.md

+5-5
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ cat <<- EOF > "${CARVEL_PACKAGE_HOME}/packages/${CARVEL_PACKAGE_NAME}.${CARVEL_P
130130
apiVersion: kctrl.carvel.dev/v1alpha1
131131
kind: PackageBuild
132132
metadata:
133-
creationTimestamp: null
133+
creationTimestamp: "$(date -u +"%Y-%m-%dT%H:%M:%SZ")"
134134
name: ${CARVEL_PACKAGE_NAME}.${CARVEL_PACKAGE_FQDN}
135135
spec:
136136
release:
@@ -170,12 +170,14 @@ cat <<- EOF > "${CARVEL_PACKAGE_HOME}/packages/${CARVEL_PACKAGE_NAME}.${CARVEL_P
170170
apiVersion: data.packaging.carvel.dev/v1alpha1
171171
kind: PackageMetadata
172172
metadata:
173-
creationTimestamp: null
173+
creationTimestamp: "$(date -u +"%Y-%m-%dT%H:%M:%SZ")"
174174
name: ${CARVEL_PACKAGE_NAME}.${CARVEL_PACKAGE_FQDN}
175175
spec:
176176
displayName: ${CARVEL_PACKAGE_NAME}
177177
longDescription: ${CARVEL_PACKAGE_NAME}.${CARVEL_PACKAGE_FQDN}
178178
shortDescription: ${CARVEL_PACKAGE_NAME}.${CARVEL_PACKAGE_FQDN}
179+
maintainers: []
180+
categories: []
179181
EOF
180182

181183
# Package Readme
@@ -593,9 +595,7 @@ stringData:
593595
values.yaml: |
594596
---
595597
596-
# Place value overrides here.
597-
598-
registry: harbor.internal.lan
598+
# Place value overrides for your specific package here.
599599
600600
EOF
601601
```

Diff for: content/tutorials/carvel/packages/author/hard/repository.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,7 @@ metadata:
237237
name: ${PACKAGE_NAME}
238238
namespace: ${PACKAGE_NAMESPACE}
239239
spec:
240-
serviceAccountName: ${PACKAGE_NAMESPACE}-sa
240+
serviceAccountName: ${PACKAGE_SA}
241241
packageRef:
242242
refName: ${PACKAGE_NAME}.${PACKAGE_FQN}
243243
versionSelection:

Diff for: content/tutorials/carvel/packages/author/hard/variables.md

+3
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,9 @@ PACKAGE_AUTHOR_EMAIL="[email protected]"
6161
# Package Author website
6262
PACKAGE_WEBSITE="https://saltlabs.tech"
6363

64+
# What is the service account that is used to install packages
65+
PACKAGE_SA="kapp-controller-sa"
66+
6467
# What is the version of the repository you will be creating?
6568
REPOSITORY_VERSION="$(date +%Y-%m-%d)"
6669

0 commit comments

Comments
 (0)