You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Just letting you know of a potential problem coming. I have a CI running my code at work on beta rust, clippy, fmt, etc and recently there's been a new warning when using rocket_ws::WebSocket. It seems it could originate somewhere in rocket's macro:
warning: unreachable pattern
--> src/main.rs:5:9
|
5 | ws: rocket_ws::WebSocket,
| ^^^^^^^^^ matches no values because `(rocket::http::Status, Infallible)` is uninhabited
|
= note: to learn more about uninhabited types, see https://doc.rust-lang.org/nomicon/exotic-sizes.html#empty-types
= note: `#[warn(unreachable_patterns)]` on by default
Below is a somewhat minimal reproduction code.
Test Case
use rocket::{get, response::status::NotFound};#[get("/endpoint")]pubasyncfnendpoint(ws: rocket_ws::WebSocket,) -> Result<rocket_ws::Channel<'static>,NotFound<()>>{Ok(ws.channel(|_| Box::pin(async{Ok(())})))}fnmain(){}
Log Output
warning: unreachable pattern
--> src/main.rs:5:9
|
5 | ws: rocket_ws::WebSocket,
| ^^^^^^^^^ matches no values because `(rocket::http::Status, Infallible)` is uninhabited
|
= note: to learn more about uninhabited types, see https://doc.rust-lang.org/nomicon/exotic-sizes.html#empty-types
= note: `#[warn(unreachable_patterns)]` on by default
Additional Context
No response
System Checks
My bug report relates to functionality.
I have tested against the latest Rocket release or a recent git commit.
I have tested against the latest stable rustc toolchain.
I was unable to find this issue previously reported.
The text was updated successfully, but these errors were encountered:
Rocket Version
0.5.1
Operating System
Ubuntu 22.04.4
Rust Toolchain Version
1.82.0-beta.3
What happened?
Just letting you know of a potential problem coming. I have a CI running my code at work on beta rust, clippy, fmt, etc and recently there's been a new warning when using
rocket_ws::WebSocket
. It seems it could originate somewhere in rocket's macro:Below is a somewhat minimal reproduction code.
Test Case
Log Output
Additional Context
No response
System Checks
rustc
toolchain.The text was updated successfully, but these errors were encountered: