Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websockets (and any other connection upgrade) does not support local testing. #2838

Open
2 tasks done
the10thWiz opened this issue Aug 2, 2024 · 0 comments
Open
2 tasks done
Labels
request Request for new functionality

Comments

@the10thWiz
Copy link
Collaborator

What's missing?

As noted in #2836, Websockets cannot be tested with a local client. Ideally, local::Client should expose the ability to perform a connection upgrade, so that rocket_ws can implement proper testing functionality.

Ideal Solution

No response

Why can't this be implemented outside of Rocket?

Although web socket specific code can and should live outside Rocket, the local client code needs to support the upgrade mechanism to allow the external implementation.

Are there workarounds usable today?

No response

Alternative Solutions

No response

Additional Context

No response

System Checks

  • I do not believe that this feature can or should be implemented outside of Rocket.
  • I was unable to find a previous request for this feature.
@the10thWiz the10thWiz added the request Request for new functionality label Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
request Request for new functionality
Projects
None yet
Development

No branches or pull requests

1 participant